fix(eventlog) add *EventInProgress.Append method
Juan Batiz-Benet committed
Jan 31, 2015 at 01:50 UTC
2d9550f284ddf6ef27ce4852f813f888c8f924ff
1 file changed
+7
-7
thirdparty/eventlog/log.go
+7
-7
@@ -49,7 +49,7 @@ type EventLogger interface {
49
// the metadata is logged.
50
Event(ctx context.Context, event string, m ...Loggable)
51
52
- EventBegin(ctx context.Context, event string, m ...Loggable) EventInProgress
52
+ EventBegin(ctx context.Context, event string, m ...Loggable) *EventInProgress
53
}
54
55
// Logger retrieves an event logger by name
@@ -68,11 +68,11 @@ type eventLogger struct {
68
// TODO add log-level
69
}
70
71
-func (el *eventLogger) EventBegin(ctx context.Context, event string, metadata ...Loggable) EventInProgress {
71
+func (el *eventLogger) EventBegin(ctx context.Context, event string, metadata ...Loggable) *EventInProgress {
72
start := time.Now()
73
el.Event(ctx, fmt.Sprintf("%sBegin", event), metadata...)
74
75
- eip := EventInProgress{}
75
+ eip := &EventInProgress{}
76
eip.doneFunc = func(additional []Loggable) {
77
78
metadata = append(metadata, additional...) // anything added during the operation
@@ -116,12 +116,12 @@ type EventInProgress struct {
116
}
117
118
// Append adds loggables to be included in the call to Done
119
-func (eip EventInProgress) Append(l Loggable) {
119
+func (eip *EventInProgress) Append(l Loggable) {
120
eip.loggables = append(eip.loggables, l)
121
}
122
123
// SetError includes the provided error
124
-func (eip EventInProgress) SetError(err error) {
124
+func (eip *EventInProgress) SetError(err error) {
125
eip.loggables = append(eip.loggables, LoggableMap{
126
"error": err.Error(),
127
})
@@ -129,12 +129,12 @@ func (eip EventInProgress) SetError(err error) {
129
130
// Done creates a new Event entry that includes the duration and appended
131
// loggables.
132
-func (eip EventInProgress) Done() {
132
+func (eip *EventInProgress) Done() {
133
eip.doneFunc(eip.loggables) // create final event with extra data
134
}
135
136
// Close is an alias for done
137
-func (eip EventInProgress) Close() error {
137
+func (eip *EventInProgress) Close() error {
138
eip.Done()
139
return nil
140
}