v1.6.4

Until now a review comment was the end of the conversation. If you disagreed with one, or fixed it, nothing on the other side noticed. siGit Code Review now reads replies in the threads it opened.

#Replies in the thread

When you answer one of its comments, the reviewer checks your reply against the current diff and takes it as one of three things. If you made a fair point or deferred the issue, it says so briefly and resolves the thread. If you disagree and the problem is still there, it explains what remains. Each of your comments is answered once, and after three turns from the reviewer the maintainer's call stands and the thread is resolved, so a thread never turns into a long argument with a model.

Follow-up replies are covered by the price of the original review. They don't use any of your cloud allowance.

#A reaction on your comment

Alongside a reply, the reviewer can leave one emoji on your comment: a thumbs up for a fair point, hooray or rocket when you shipped the fix, a heart when you thanked it, eyes while it is still looking. It skips the reaction when nothing fits and never uses a thumbs down. Reactions are GitHub only for now, and native siGit pull requests get the reply without one.

#Approval

Once every thread from a review that is not a nit is resolved or outdated, the reviewer approves that head commit. On native siGit pull requests the approval is visible but does not count toward the required human approvals in branch protection.

#For GitHub App owners

Following up needs three more webhook events on the siGit Code Review GitHub App: pull request review, pull request review comment, and pull request review thread. Without them reviews behave as before and replies go unanswered.

---

Release masters: @setoelkahfi and @sigit.