@cryptotaxi247 / kubo / commits / 670b2b59b

p2p/net/swarm: fix racey test

Juan Batiz-Benet committed Jan 13, 2015 at 22:46 UTC 670b2b59b50a552b8025b8b86c04cbd98c9e1ea2
1 file changed +4 -8
p2p/net/swarm/swarm_addr_test.go
+4 -8
@@ -26,13 +26,13 @@ func TestFilterAddrs(t *testing.T) {
26 m("/ip4/1.2.3.4/udp/1234/sctp/1234"), // not in manet
27 m("/ip4/1.2.3.4/udp/1234/utp"), // utp is broken
28 m("/ip4/1.2.3.4/udp/1234/udt"), // udt is broken on arm
29 - m("/ip6/fe80::1/tcp/1234"), // link local
29 + m("/ip6/fe80::1/tcp/0"), // link local
30 m("/ip6/fe80::100/tcp/1234"), // link local
31 }
32
33 good := []ma.Multiaddr{
34 - m("/ip4/127.0.0.1/tcp/1234"),
35 - m("/ip6/::1/tcp/1234"),
34 + m("/ip4/127.0.0.1/tcp/0"),
35 + m("/ip6/::1/tcp/0"),
36 }
37
38 goodAndBad := append(good, bad...)
@@ -69,13 +69,9 @@ func TestFilterAddrs(t *testing.T) {
69 t.Fatal("should have failed to create swarm")
70 }
71
72 - if _, err := NewNetwork(ctx, good, id, ps); err != nil {
72 + if _, err := NewNetwork(ctx, goodAndBad, id, ps); err != nil {
73 t.Fatal("should have succeeded in creating swarm", err)
74 }
75 -
76 - if _, err := NewNetwork(ctx, goodAndBad, id, ps); err == nil {
77 - t.Fatal("should have failed to create swarm")
78 - }
75 }
76
77 func subtestAddrsEqual(t *testing.T, a, b []ma.Multiaddr) {