v1.6.5
Review threads that keep up with your pushes
v1.6.4 taught siGit Code Review to answer replies in its threads. In practice it often stayed quiet. Fixing, pushing, and then replying is the normal order, and any push after the review silenced every follow-up. This release makes the thread read more like a conversation with a colleague.
Pushing no longer ends the conversation
Threads belong to the pull request now, not to the commit they were posted on. A reply is answered after any number of pushes, including on a thread from an earlier review, and the reviewer always judges it against the current code. Follow-ups wait about a minute before answering, so if you reply and push right after, your reply is judged against the pushed code.
Fixes you push without replying
About two minutes after a push, the reviewer looks at its open threads that nobody
answered and whose code changed. If the push fixed the problem, it says so in one line,
like "Looks fixed in abc1234.", and resolves the thread. If not, it says nothing, and
the review of the new head covers what is left.
Your call stands when you resolve
If you reply and resolve the thread yourself, the reviewer only reacts to your comment. It doesn't post a reply and never reopens the thread.
Approval waits for a reviewed head
The reviewer approves once every thread that is not a nit is resolved or outdated, and only if the latest head was itself reviewed. If the review of your last push failed or is still queued, there is no approval yet. Approvals, "looks fixed" notes, and the line it defers with after three turns are short and don't repeat on the same pull request.
Release masters: @setoelkahfi and @sigit.