Don't overwrite netdata.conf on update on static installs. (#9046)
* Don't overwrite netdata.conf on update on static installs. The current code overwrites netdata.conf when updating a static install because we include a copy of the default empty netdata.conf in the package itself. This removes that file from the generated package, but does not modify the install-time logic which attempts to create the file if it does not already exist (which appears to be working correctly. * Update packaging/makeself/jobs/70-netdata-git.install.sh Co-authored-by: James Mills <prologic@shortcircuit.net.au> Co-authored-by: James Mills <prologic@shortcircuit.net.au>
Austin S. Hemmelgarn committed
May 19, 2020 at 18:02 UTC
254183a2e34ebc3accbb03bfcc7e53534f731a97
1 file changed
+3
packaging/makeself/jobs/70-netdata-git.install.sh
+3
@@ -22,6 +22,9 @@ run ./netdata-installer.sh --install "${NETDATA_INSTALL_PARENT}" \
22
--dont-start-it \
23
${NULL}
24
25
+# Remove the netdata.conf file from the tree. It has hard-coded sensible defaults builtin.
26
+rm -f "${NETDATA_INSTALL_PARENT}/etc/netdata/netdata.conf"
27
+
28
if [ ${NETDATA_BUILD_WITH_DEBUG} -eq 0 ]
29
then
30
run strip ${NETDATA_INSTALL_PATH}/bin/netdata