@cryptotaxi247 / netdata-1 / commits / 42f7d7acb

Fix coverity warnings on get_system_info (#5952)

Chris Akritidis committed May 3, 2019 at 12:55 UTC 42f7d7acb7e43b82cbafa18c167b9b7c778d0694
1 file changed +9 -6
daemon/main.c
+9 -6
@@ -674,12 +674,15 @@ int get_system_info () {
674 if (*value=='=') {
675 *value='\0';
676 value++;
677 - char *newline = value + strlen(value) - 1;
678 - (*newline)='\0';
679 - }
680 - if (name && value && *name && *value) {
681 - info("%s=%s", name, value);
682 - setenv(name, value, 1);
677 + if (strlen(value)>1) {
678 + char *newline = value + strlen(value) - 1;
679 + (*newline) = '\0';
680 + }
681 + char n[51], v[101];
682 + snprintfz(n,50,"%s",name);
683 + snprintfz(v,101,"%s",value);
684 + info("%s=%s", n, v);
685 + setenv(n, v, 1);
686 }
687 }
688 mypclose(fp, command_pid);