Missing checks exporting (#9034)
Add tests to uv_mutex_init and uv_cond_init inside exporting.
thiagoftsm committed
May 26, 2020 at 12:50 UTC
605705a164e2ef562b7b309cf5607918978bc039
5 files changed
+24
-12
exporting/aws_kinesis/aws_kinesis.c
+4
-2
@@ -56,8 +56,10 @@ int init_aws_kinesis_instance(struct instance *instance)
56
error("EXPORTING: cannot create buffer for AWS Kinesis exporting connector instance %s", instance->config.name);
57
return 1;
58
}
59
- uv_mutex_init(&instance->mutex);
60
- uv_cond_init(&instance->cond_var);
59
+ if (uv_mutex_init(&instance->mutex))
60
+ return 1;
61
+ if (uv_cond_init(&instance->cond_var))
62
+ return 1;
63
64
if (!instance->engine->aws_sdk_initialized) {
65
aws_sdk_init();
exporting/graphite/graphite.c
+4
-2
@@ -37,8 +37,10 @@ int init_graphite_instance(struct instance *instance)
37
error("EXPORTING: cannot create buffer for graphite exporting connector instance %s", instance->config.name);
38
return 1;
39
}
40
- uv_mutex_init(&instance->mutex);
41
- uv_cond_init(&instance->cond_var);
40
+ if (uv_mutex_init(&instance->mutex))
41
+ return 1;
42
+ if (uv_cond_init(&instance->cond_var))
43
+ return 1;
44
45
return 0;
46
}
exporting/json/json.c
+4
-2
@@ -37,8 +37,10 @@ int init_json_instance(struct instance *instance)
37
error("EXPORTING: cannot create buffer for json exporting connector instance %s", instance->config.name);
38
return 1;
39
}
40
- uv_mutex_init(&instance->mutex);
41
- uv_cond_init(&instance->cond_var);
40
+ if (uv_mutex_init(&instance->mutex))
41
+ return 1;
42
+ if (uv_cond_init(&instance->cond_var))
43
+ return 1;
44
45
return 0;
46
}
exporting/opentsdb/opentsdb.c
+8
-4
@@ -37,8 +37,10 @@ int init_opentsdb_telnet_instance(struct instance *instance)
37
error("EXPORTING: cannot create buffer for opentsdb telnet exporting connector instance %s", instance->config.name);
38
return 1;
39
}
40
- uv_mutex_init(&instance->mutex);
41
- uv_cond_init(&instance->cond_var);
40
+ if (uv_mutex_init(&instance->mutex))
41
+ return 1;
42
+ if (uv_cond_init(&instance->cond_var))
43
+ return 1;
44
45
return 0;
46
}
@@ -78,8 +80,10 @@ int init_opentsdb_http_instance(struct instance *instance)
80
error("EXPORTING: cannot create buffer for opentsdb HTTP exporting connector instance %s", instance->config.name);
81
return 1;
82
}
81
- uv_mutex_init(&instance->mutex);
82
- uv_cond_init(&instance->cond_var);
83
+ if (uv_mutex_init(&instance->mutex))
84
+ return 1;
85
+ if (uv_cond_init(&instance->cond_var))
86
+ return 1;
87
88
return 0;
89
}
exporting/prometheus/remote_write/remote_write.c
+4
-2
@@ -122,8 +122,10 @@ int init_prometheus_remote_write_instance(struct instance *instance)
122
error("EXPORTING: cannot create buffer for AWS Kinesis exporting connector instance %s", instance->config.name);
123
return 1;
124
}
125
- uv_mutex_init(&instance->mutex);
126
- uv_cond_init(&instance->cond_var);
125
+ if (uv_mutex_init(&instance->mutex))
126
+ return 1;
127
+ if (uv_cond_init(&instance->cond_var))
128
+ return 1;
129
130
struct prometheus_remote_write_specific_data *connector_specific_data =
131
callocz(1, sizeof(struct prometheus_remote_write_specific_data));