Remove temp log file if no update needed (#5695)
Chris Akritidis committed
Mar 24, 2019 at 13:37 UTC
84c1fe678f72e86ac18d6dd4d68008198f8f0413
1 file changed
+26
-27
packaging/installer/netdata-updater.sh
+26
-27
@@ -77,36 +77,35 @@ update() {
77
download "${NETDATA_TARBALL_CHECKSUM_URL}" "${dir}/sha256sum.txt" >&3 2>&3
78
if grep "${NETDATA_TARBALL_CHECKSUM}" sha256sum.txt >&3 2>&3; then
79
info "Newest version is already installed"
80
- exit 0
81
- fi
82
-
83
- download "${NETDATA_TARBALL_URL}" "${dir}/netdata-latest.tar.gz"
84
- if ! grep netdata-latest.tar.gz sha256sum.txt | sha256sum --check - >&3 2>&3; then
85
- failed "Tarball checksum validation failed. Stopping netdata upgrade and leaving tarball in ${dir}"
86
- fi
87
- NEW_CHECKSUM="$(sha256sum netdata-latest.tar.gz 2>/dev/null| cut -d' ' -f1)"
88
- tar -xf netdata-latest.tar.gz >&3 2>&3
89
- rm netdata-latest.tar.gz >&3 2>&3
90
- cd netdata-*
91
-
92
- # signal netdata to start saving its database
93
- # this is handy if your database is big
94
- pids=$(pidof netdata)
95
- do_not_start=
96
- if [ -n "${pids}" ]; then
97
- #shellcheck disable=SC2086
98
- kill -USR1 ${pids}
80
else
100
- # netdata is currently not running, so do not start it after updating
101
- do_not_start="--dont-start-it"
102
- fi
103
-
104
- info "Re-installing netdata..."
105
- eval "${REINSTALL_COMMAND} --dont-wait ${do_not_start}" >&3 2>&3 || fatal "FAILED TO COMPILE/INSTALL NETDATA"
106
- sed -i '/NETDATA_TARBALL/d' "${ENVIRONMENT_FILE}"
107
- cat <<EOF >>"${ENVIRONMENT_FILE}"
81
+ download "${NETDATA_TARBALL_URL}" "${dir}/netdata-latest.tar.gz"
82
+ if ! grep netdata-latest.tar.gz sha256sum.txt | sha256sum --check - >&3 2>&3; then
83
+ failed "Tarball checksum validation failed. Stopping netdata upgrade and leaving tarball in ${dir}"
84
+ fi
85
+ NEW_CHECKSUM="$(sha256sum netdata-latest.tar.gz 2>/dev/null| cut -d' ' -f1)"
86
+ tar -xf netdata-latest.tar.gz >&3 2>&3
87
+ rm netdata-latest.tar.gz >&3 2>&3
88
+ cd netdata-*
89
+
90
+ # signal netdata to start saving its database
91
+ # this is handy if your database is big
92
+ pids=$(pidof netdata)
93
+ do_not_start=
94
+ if [ -n "${pids}" ]; then
95
+ #shellcheck disable=SC2086
96
+ kill -USR1 ${pids}
97
+ else
98
+ # netdata is currently not running, so do not start it after updating
99
+ do_not_start="--dont-start-it"
100
+ fi
101
+
102
+ info "Re-installing netdata..."
103
+ eval "${REINSTALL_COMMAND} --dont-wait ${do_not_start}" >&3 2>&3 || fatal "FAILED TO COMPILE/INSTALL NETDATA"
104
+ sed -i '/NETDATA_TARBALL/d' "${ENVIRONMENT_FILE}"
105
+ cat <<EOF >>"${ENVIRONMENT_FILE}"
106
NETDATA_TARBALL_CHECKSUM="$NEW_CHECKSUM"
107
EOF
108
+ fi
109
110
rm -rf "${dir}" >&3 2>&3
111
[ -n "${logfile}" ] && rm "${logfile}" && logfile=