Mirrored from https://github.com/Camo67/OCIU-npo.git
Synced Nov 21, 03:37 UTC
fix/restore-static-site
Security Improvements Made
1. CORS Configuration (Backend)
Issue: The backend was using allow_origins=["*"] which allows any website to make requests to your API, potentially exposing sensitive data.
Fix: - Replaced wildcard with environment-based configuration - Restricted HTTP methods to only those needed (GET, POST, PUT, DELETE, OPTIONS) - Limited allowed headers to specific ones (Content-Type, Authorization, X-User-Id) - Added max_age for preflight caching
allowed_origins = os.getenv("ALLOWED_ORIGINS", "http://localhost:5173,http://localhost:3000").split(",")
app.add_middleware(
CORSMiddleware,
allow_origins=allowed_origins,
allow_credentials=True,
allow_methods=["GET", "POST", "PUT", "DELETE", "OPTIONS"],
allow_headers=["Content-Type", "Authorization", "X-User-Id"],
expose_headers=["X-Request-Id"],
max_age=600,
)
2. Hardcoded API URLs (Frontend)
Issue: Dashboard component had hardcoded http://localhost:8000 URLs which breaks in production.
Fix:
- Added environment variable support via VITE_API_URL
- Falls back to window.location.origin for same-origin deployments
- Updated both EventSource and fetch calls
const API_BASE_URL = import.meta.env.VITE_API_URL || window.location.origin;
3. Environment Configuration
Created .env.example with all required environment variables documented.
Additional Recommendations
High Priority
- Add Authentication: Implement proper JWT-based authentication instead of relying on X-User-Id header
- Rate Limiting: Add rate limiting middleware to prevent abuse
- Input Validation: Use Pydantic models with strict validation for all API endpoints
- HTTPS: Ensure production uses HTTPS only
- Secrets Management: Never commit .env files; use secrets management in production
Medium Priority
- CSRF Protection: Add CSRF tokens for state-changing operations
- Security Headers: Add Content-Security-Policy, X-Frame-Options, etc.
- Logging & Monitoring: Implement proper audit logging
- Error Handling: Ensure errors don't leak sensitive information
Mobile & Desktop Responsiveness
The codebase already has good responsive design with Tailwind CSS breakpoints:
- md: prefix for tablet (768px+)
- lg: prefix for desktop (1024px+)
- xl: and 2xl: for larger screens
Verified Components: - ✅ Navigation - Mobile hamburger menu with responsive breakpoints - ✅ Hero - Responsive text sizes and logo scaling - ✅ DigitalAgency - Grid layouts that adapt to screen size - ✅ CallToAction - Flexible form layout - ✅ Dashboard - Multi-column grid system
Recommendations:
1. Test on actual devices (iOS Safari, Android Chrome)
2. Add touch-friendly tap targets (min 44x44px)
3. Consider adding sm: breakpoints for better small phone support
4. Add meta viewport tag is already present ✅