The best way to control Claude Code, Codex and more from any computer or phone
| 1 | import "~/index.css"; |
| 2 | import { EnvironmentId, ProjectId } from "@t3tools/contracts"; |
| 3 | import { sourceControlClients } from "@t3tools/client-runtime/source-control-clients"; |
| 4 | import { Cause } from "effect"; |
| 5 | import { expect, it, vi } from "vite-plus/test"; |
| 6 | import { page } from "vite-plus/test/browser"; |
| 7 | |
| 8 | const mocks = vi.hoisted(() => ({ |
| 9 | update: |
| 10 | vi.fn<(input: unknown) => Promise<{ _tag: "Success" } | { _tag: "Failure"; cause: unknown }>>(), |
| 11 | notify: vi.fn(), |
| 12 | })); |
| 13 | vi.mock( |
| 14 | import("~/state/pullRequests"), |
| 15 | () => ({ pullRequestEnvironment: { update: {} } }) as never, |
| 16 | ); |
| 17 | vi.mock( |
| 18 | import("~/state/use-atom-command"), |
| 19 | () => ({ useAtomCommand: () => mocks.update }) as never, |
| 20 | ); |
| 21 | |
| 22 | vi.mock(import("../ui/toast"), () => ({ toastManager: { add: mocks.notify } }) as never); |
| 23 | vi.mock(import("~/state/server"), async () => { |
| 24 | const { Atom } = await import("effect/reactivity"); |
| 25 | return { primaryServerKeybindingsAtom: Atom.make([]) } as never; |
| 26 | }); |
| 27 | vi.mock(import("~/browser/useOpenLink"), () => ({ useOpenLink: () => async () => {} })); |
| 28 | vi.mock(import("./PullRequestThreadLinks"), () => ({ PullRequestThreadLinks: () => null })); |
| 29 | vi.mock( |
| 30 | import("./PullRequestDetailActions"), |
| 31 | () => ({ ActOnEnvironmentPicker: () => null }) as never, |
| 32 | ); |
| 33 | |
| 34 | import { render } from "../../../test/render"; |
| 35 | import { PullRequestActionsMenu } from "./PullRequestActionsMenu"; |
| 36 | |
| 37 | const reference = { projectId: ProjectId.make("project"), repository: "owner/repo", number: 7 }; |
| 38 | const environmentId = EnvironmentId.make("environment"); |
| 39 | |
| 40 | type Detail = Parameters<typeof PullRequestActionsMenu>[0]["detail"]; |
| 41 | |
| 42 | const openDetail: Detail = { |
| 43 | url: "https://github.com/owner/repo/pull/7", |
| 44 | state: "open", |
| 45 | isDraft: false, |
| 46 | headBranch: "feature", |
| 47 | maintainerCanModify: true, |
| 48 | observedAt: 1, |
| 49 | capabilities: { |
| 50 | diff: true, |
| 51 | comment: true, |
| 52 | actions: [], |
| 53 | mergeMethods: [], |
| 54 | search: true, |
| 55 | review: { inlineComment: true, reply: true, resolve: true, verdicts: [] }, |
| 56 | reviewers: { request: true, listCandidates: true }, |
| 57 | edit: { changeRequest: true, comment: true, maintainerEdits: true }, |
| 58 | }, |
| 59 | viewerPermissions: { |
| 60 | actions: [], |
| 61 | comment: true, |
| 62 | resolve: true, |
| 63 | verdicts: [], |
| 64 | requestReviewers: true, |
| 65 | maintainerEdits: true, |
| 66 | }, |
| 67 | }; |
| 68 | |
| 69 | function setup() { |
| 70 | mocks.update.mockReset().mockResolvedValue({ _tag: "Success" }); |
| 71 | mocks.notify.mockReset(); |
| 72 | return (detail: Detail = openDetail) => ( |
| 73 | <PullRequestActionsMenu |
| 74 | environmentId={environmentId} |
| 75 | reference={reference} |
| 76 | pullRequestKey="owner/repo/7" |
| 77 | detail={detail} |
| 78 | terminology={sourceControlClients.get("github").changeRequest} |
| 79 | threadRef={null} |
| 80 | linkThreadRef={null} |
| 81 | onThreadPickerOpenChange={() => {}} |
| 82 | refreshing={false} |
| 83 | refreshFromHost={async () => {}} |
| 84 | handoff={null} |
| 85 | attachesToComposer={false} |
| 86 | askAboutPullRequest={() => {}} |
| 87 | explainPullRequest={() => {}} |
| 88 | canFixFindings={false} |
| 89 | startFixFindings={() => {}} |
| 90 | handoffLabels={{ fixFindings: "Fix review findings" }} |
| 91 | canWriteGuide={false} |
| 92 | guideRunning={false} |
| 93 | guideWritten={false} |
| 94 | writeGuide={() => {}} |
| 95 | pickableEnvironments={[]} |
| 96 | actingEnvironmentId={environmentId} |
| 97 | onActingEnvironmentChange={() => {}} |
| 98 | can={() => false} |
| 99 | autoMergeArmed={false} |
| 100 | showsDraftToggle={false} |
| 101 | showsMergeNow={false} |
| 102 | showsAutoMerge={false} |
| 103 | showsMergeMethods={false} |
| 104 | allowedMergeMethods={[]} |
| 105 | selectedMergeMethod="squash" |
| 106 | onSelectMergeMethod={() => {}} |
| 107 | showsDeleteBranch={false} |
| 108 | environmentConnected={true} |
| 109 | canWriteSourceControl={true} |
| 110 | onMaintainerEditsSaved={() => {}} |
| 111 | confirmDeleteBranch={async () => {}} |
| 112 | pendingAction={null} |
| 113 | perform={async () => true} |
| 114 | openOnHostText="Open on GitHub" |
| 115 | copyReference={() => {}} |
| 116 | /> |
| 117 | ); |
| 118 | } |
| 119 | |
| 120 | it("saves maintainer edits, locks while saving, and restores the saved value when a save fails", async () => { |
| 121 | const control = setup(); |
| 122 | await using screen = await render(control()); |
| 123 | await screen.getByRole("button", { name: "More pull request actions" }).click(); |
| 124 | const checkbox = page.getByRole("menuitemcheckbox", { name: "Allow edits from maintainers" }); |
| 125 | await expect.element(checkbox).toBeChecked(); |
| 126 | await checkbox.click(); |
| 127 | await expect.element(page.getByRole("status")).not.toBeInTheDocument(); |
| 128 | expect(mocks.update).toHaveBeenCalledExactlyOnceWith({ |
| 129 | environmentId, |
| 130 | input: { ...reference, maintainerCanModify: false }, |
| 131 | }); |
| 132 | |
| 133 | let settle!: (value: { _tag: "Failure"; cause: unknown }) => void; |
| 134 | mocks.update.mockReturnValueOnce( |
| 135 | new Promise((resolve) => { |
| 136 | settle = resolve; |
| 137 | }), |
| 138 | ); |
| 139 | await checkbox.click(); |
| 140 | await expect.element(checkbox).toBeChecked(); |
| 141 | await expect.element(checkbox).toBeDisabled(); |
| 142 | await expect.element(page.getByRole("status")).toHaveTextContent("Saving…"); |
| 143 | settle({ |
| 144 | _tag: "Failure", |
| 145 | cause: Cause.fail(new Error("Resource not accessible by integration")), |
| 146 | }); |
| 147 | await expect.element(checkbox).not.toBeChecked(); |
| 148 | expect(mocks.notify).toHaveBeenCalledExactlyOnceWith( |
| 149 | expect.objectContaining({ |
| 150 | type: "error", |
| 151 | title: "Could not save maintainer access", |
| 152 | description: "Resource not accessible by integration", |
| 153 | }), |
| 154 | ); |
| 155 | }); |
| 156 | |
| 157 | it("keeps a saved choice through a stale refresh, then follows the host", async () => { |
| 158 | const control = setup(); |
| 159 | await using screen = await render(control()); |
| 160 | await screen.getByRole("button", { name: "More pull request actions" }).click(); |
| 161 | const checkbox = page.getByRole("menuitemcheckbox", { name: "Allow edits from maintainers" }); |
| 162 | let settle!: (value: { _tag: "Success" }) => void; |
| 163 | mocks.update.mockReturnValueOnce( |
| 164 | new Promise((resolve) => { |
| 165 | settle = resolve; |
| 166 | }), |
| 167 | ); |
| 168 | await checkbox.click(); |
| 169 | await screen.rerender(control({ ...openDetail, observedAt: 2 })); |
| 170 | settle({ _tag: "Success" }); |
| 171 | await expect.element(page.getByRole("status")).not.toBeInTheDocument(); |
| 172 | await screen.rerender(control({ ...openDetail, observedAt: 2 })); |
| 173 | await expect.element(checkbox).not.toBeChecked(); |
| 174 | await screen.rerender(control({ ...openDetail, maintainerCanModify: false, observedAt: 3 })); |
| 175 | await expect.element(checkbox).not.toBeChecked(); |
| 176 | await screen.rerender(control({ ...openDetail, maintainerCanModify: true, observedAt: 4 })); |
| 177 | await expect.element(checkbox).toBeChecked(); |
| 178 | }); |
| 179 | |
| 180 | it("follows the host's first reading after a save, even when it matches the old value", async () => { |
| 181 | const control = setup(); |
| 182 | await using screen = await render(control()); |
| 183 | await screen.getByRole("button", { name: "More pull request actions" }).click(); |
| 184 | const checkbox = page.getByRole("menuitemcheckbox", { name: "Allow edits from maintainers" }); |
| 185 | await checkbox.click(); |
| 186 | await expect.element(page.getByRole("status")).not.toBeInTheDocument(); |
| 187 | await expect.element(checkbox).not.toBeChecked(); |
| 188 | await screen.rerender(control({ ...openDetail, observedAt: 2 })); |
| 189 | await expect.element(checkbox).toBeChecked(); |
| 190 | }); |
| 191 | |
| 192 | it.each<[string, Detail]>([ |
| 193 | ["closed", { ...openDetail, state: "closed" }], |
| 194 | [ |
| 195 | "not authored by the viewer", |
| 196 | { |
| 197 | ...openDetail, |
| 198 | viewerPermissions: { ...openDetail.viewerPermissions, maintainerEdits: false }, |
| 199 | }, |
| 200 | ], |
| 201 | [ |
| 202 | "on a host without maintainer edits", |
| 203 | { |
| 204 | ...openDetail, |
| 205 | capabilities: { ...openDetail.capabilities, edit: { changeRequest: true, comment: true } }, |
| 206 | }, |
| 207 | ], |
| 208 | ])("hides maintainer edits on a pull request that is %s", async (_, detail) => { |
| 209 | const control = setup(); |
| 210 | await using screen = await render(control(detail)); |
| 211 | await screen.getByRole("button", { name: "More pull request actions" }).click(); |
| 212 | await expect.element(page.getByRole("menuitem", { name: "Open on GitHub" })).toBeVisible(); |
| 213 | expect(document.querySelector('[role="menuitemcheckbox"]')).toBeNull(); |
| 214 | }); |