bloom: remove a misleading const qualifier
When building with glibc-2.43 there is the following warning: bloom.c: In function ‘get_or_compute_bloom_filter’: bloom.c:515:52: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] 515 | char *last_slash = strrchr(path, '/'); | ^~~~~~~ In this case, we always write through "path" through the "last_slash" pointer. Therefore, the const qualifier on "path" is misleading and we can just remove it. Signed-off-by: Collin Funk <collin.funk1@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Collin Funk committed
Mar 8, 2026 at 19:55 UTC
1ac1d4e761c5f394526873b364ba23cf5b9b0da5
1 file changed
+2
-2
bloom.c
+2
-2
index 2d7b951e5b..d604e8f07a 100644
--- a/bloom.c
+++ b/bloom.c
@@ -501,7 +501,7 @@ struct bloom_filter *get_or_compute_bloom_filter(struct repository *r,
struct hashmap_iter iter;
for (i = 0; i < diff_queued_diff.nr; i++) {
- const char *path = diff_queued_diff.queue[i]->two->path;
+ char *path = diff_queued_diff.queue[i]->two->path;
/*
* Add each leading directory of the changed file, i.e. for
@@ -523,7 +523,7 @@ struct bloom_filter *get_or_compute_bloom_filter(struct repository *r,
free(e);
if (!last_slash)
- last_slash = (char*)path;
+ last_slash = path;
*last_slash = '\0';
} while (*path);