replay: die if we cannot parse object
`parse_object` can return `NULL`. That will in turn make `repo_peel_to_type` return the same. Let’s die fast and descriptively with the `*_or_die` variant. Suggested-by: Junio C Hamano <gitster@pobox.com> Signed-off-by: Kristoffer Haugsbakk <code@khaugsbakk.name> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Kristoffer Haugsbakk committed
Jan 5, 2026 at 20:53 UTC
6f693364cc183ea5a8296c9ce2ff515f47206f92
1 file changed
+1
-1
builtin/replay.c
+1
-1
index 402db44af2..1960bbbee8 100644
--- a/builtin/replay.c
+++ b/builtin/replay.c
@@ -42,7 +42,7 @@ static struct commit *peel_committish(struct repository *repo,
if (repo_get_oid(repo, name, &oid))
die(_("'%s' is not a valid commit-ish for %s"), name, mode);
- obj = parse_object(repo, &oid);
+ obj = parse_object_or_die(repo, &oid, name);
return (struct commit *)repo_peel_to_type(repo, name, 0, obj,
OBJ_COMMIT);
}