Retroactively adding a filter can be useful for existing shallow clones as
they allow users to see earlier change histories without downloading all
git objects in a regular --unshallow fetch.
Without this patch, users can make a clone partial by editing the
repository configuration to convert the remote into a promisor, like:
git config core.repositoryFormatVersion 1
git config extensions.partialClone origin
git fetch --unshallow --filter=blob:none origin
Since the hard part of making this work is already in place and such
edits can be error-prone, teach Git to perform the required configuration
change automatically instead.
Note that this change does not modify the existing git behavior which
recognizes setting extensions.partialClone without changing
repositoryFormatVersion.
Signed-off-by: Xin Li <delphij@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Xin Li committedJun 5, 2020 at 02:10 UTC01bbbbd9daaa277a95ae46e5a32f6fba026610ac
5 files changed+12-6
builtin/fetch.c
-3
index b5788c16bf..3347d578ea 100644--- a/builtin/fetch.c+++ b/builtin/fetch.c@@ -1790,9 +1790,6 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) if (depth || deepen_since || deepen_not.nr) deepen = 1;- if (filter_options.choice && !has_promisor_remote())- die("--filter can only be used when extensions.partialClone is set");- if (all) { if (argc == 1) die(_("fetch --all does not take a repository argument"));
t/t0410-partial-clone.sh
+12
index a3988bd4b8..16ad000382 100755--- a/t/t0410-partial-clone.sh+++ b/t/t0410-partial-clone.sh@@ -30,6 +30,18 @@ test_expect_success 'extensions.partialclone without filter' ' git -C client fetch origin '+test_expect_success 'convert shallow clone to partial clone' '+ rm -fr server client &&+ test_create_repo server &&+ test_commit -C server my_commit 1 &&+ test_commit -C server my_commit2 1 &&+ git clone --depth=1 "file://$(pwd)/server" client &&+ git -C client fetch --unshallow --filter="blob:none" &&+ test_cmp_config -C client true remote.origin.promisor &&+ test_cmp_config -C client blob:none remote.origin.partialclonefilter &&+ test_cmp_config -C client 1 core.repositoryformatversion+'+ test_expect_success 'missing reflog object, but promised by a commit, passes fsck' ' rm -rf repo && test_create_repo repo &&