reftable: fix OOB stack write in print functions
Signed-off-by: Han-Wen Nienhuys <hanwen@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Han-Wen Nienhuys committed
Jan 20, 2022 at 15:12 UTC
32d9c0ed1e9d7ebb539dcc8ec573c025a49b9936
1 file changed
+2
-2
reftable/record.c
+2
-2
@@ -254,7 +254,7 @@ static void hex_format(char *dest, uint8_t *src, int hash_size)
254
void reftable_ref_record_print(struct reftable_ref_record *ref,
255
uint32_t hash_id)
256
{
257
- char hex[2 * GIT_SHA256_RAWSZ + 1] = { 0 }; /* BUG */
257
+ char hex[GIT_MAX_HEXSZ + 1] = { 0 }; /* BUG */
258
printf("ref{%s(%" PRIu64 ") ", ref->refname, ref->update_index);
259
switch (ref->value_type) {
260
case REFTABLE_REF_SYMREF:
@@ -586,7 +586,7 @@ static struct reftable_record_vtable reftable_obj_record_vtable = {
586
void reftable_log_record_print(struct reftable_log_record *log,
587
uint32_t hash_id)
588
{
589
- char hex[GIT_SHA256_RAWSZ + 1] = { 0 };
589
+ char hex[GIT_MAX_HEXSZ + 1] = { 0 };
590
591
switch (log->value_type) {
592
case REFTABLE_LOG_DELETION: