@matheusbsbs / matheus-bagliano / commits / 41feac6f74
Fork 0

t9400: don't use test_must_fail with cvs

We are using `test_must_fail cvs` to test that the cvs command fails as expected. However, test_must_fail() is used to ensure that commands fail in an expected way, not due to something like a segv. Since we are not in the business of verifying the sanity of the external world, replace `test_must_fail cvs` with `! cvs` and assume that the cvs command does not die unexpectedly. Signed-off-by: Denton Liu <liu.denton@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Denton Liu committed Jul 7, 2020 at 18:08 UTC 41feac6f74719922bcc0bd44683518a6d6a8a943
1 file changed +1 -1
t/t9400-git-cvsserver-server.sh
+1 -1
@@ -603,7 +603,7 @@ test_expect_success 'cvs server does not run with vanilla git-shell' '
603 cd cvswork &&
604 CVS_SERVER=$WORKDIR/remote-cvs &&
605 export CVS_SERVER &&
606 - test_must_fail cvs log merge
606 + ! cvs log merge
607 )
608 '
609