get_sha1: handle special case $commit^{/}
Empty regex pattern should always match. But the exact behavior of regexec() may vary. Because it always matches anyway, we can just return 'matched' without calling regex machinery. Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Nguyễn Thái Ngọc Duy committed
Dec 15, 2010 at 16:02 UTC
4322842acfaace812308f8aec0fe39a358f3c6f2
1 file changed
+7
sha1_name.c
+7
@@ -599,6 +599,13 @@ static int peel_onion(const char *name, int len, unsigned char *sha1)
599
int ret;
600
struct commit_list *list = NULL;
601
602
+ /*
603
+ * $commit^{/}. Some regex implementation may reject.
604
+ * We don't need regex anyway. '' pattern always matches.
605
+ */
606
+ if (sp[1] == '}')
607
+ return 0;
608
+
609
prefix = xstrndup(sp + 1, name + len - 1 - (sp + 1));
610
commit_list_insert((struct commit *)o, &list);
611
ret = get_sha1_oneline(prefix, sha1, list);