t1450-fsck: exec-bit is not needed to make loose object writable
A test case wants to append stuff to a loose object file to ensure that this kind of corruption is detected. To make a read-only loose object file writable with chmod, it is not necessary to also make it executable. Replace the bitmask 755 with the instruction +w to request only the write bit and to also heed the umask. And get rid of a POSIXPERM prerequisite, which is unnecessary for the test. Signed-off-by: Johannes Sixt <j6t@kdbg.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Sixt committed
Jan 13, 2022 at 21:28 UTC
59069107948bc87b8b6d46d49a52df410c4a8745
1 file changed
+2
-2
t/t1450-fsck.sh
+2
-2
@@ -94,13 +94,13 @@ test_expect_success 'object with hash and type mismatch' '
94
)
95
'
96
97
-test_expect_success POSIXPERM 'zlib corrupt loose object output ' '
97
+test_expect_success 'zlib corrupt loose object output ' '
98
git init --bare corrupt-loose-output &&
99
(
100
cd corrupt-loose-output &&
101
oid=$(git hash-object -w --stdin --literally </dev/null) &&
102
oidf=objects/$(test_oid_to_path "$oid") &&
103
- chmod 755 $oidf &&
103
+ chmod +w $oidf &&
104
echo extra garbage >>$oidf &&
105
106
cat >expect.error <<-EOF &&