Fix false positives in t3404 due to SHELL=/bin/false
If the user's shell in NSS passwd is /bin/false (eg as found during Gentoo's package building), the git-rebase exec tests will fail, because they call $SHELL around the command, and in the existing testcase, $SHELL was not being cleared sufficently. This lead to false positive failures of t3404 on systems where the package build user was locked down as noted above. Signed-off-by: "Robin H. Johnson" <robbat2@gentoo.org> X-Gentoo-Bug: 349083 X-Gentoo-Bug-URL: http://bugs.gentoo.org/show_bug.cgi?id=349083 Signed-off-by: Junio C Hamano <gitster@pobox.com>
Robin H. Johnson committed
Dec 27, 2010 at 08:03 UTC
5cd3e10737135163f47e97e0338dbf33f4772511
1 file changed
+2
-1
t/t3404-rebase-interactive.sh
+2
-1
@@ -67,8 +67,9 @@ test_expect_success 'setup' '
67
# "exec" commands are ran with the user shell by default, but this may
68
# be non-POSIX. For example, if SHELL=zsh then ">file" doesn't work
69
# to create a file. Unseting SHELL avoids such non-portable behavior
70
-# in tests.
70
+# in tests. It must be exported for it to take effect where needed.
71
SHELL=
72
+export SHELL
73
74
test_expect_success 'rebase -i with the exec command' '
75
git checkout master &&