@matheusbsbs / matheus-bagliano / commits / 5dcee7c705

pack-bitmap.c: continue looping when first MIDX bitmap is found

In "open_midx_bitmap()", we do a loop with the MIDX(es) in repo, when the first one has been found, then will break out by a "return" directly. But actually, it's better to continue the loop until we have visited both the MIDX in our repository, as well as any alternates (along with _their_ alternates, recursively). The reason for this is, there may exist more than one MIDX file in a repo. The "multi_pack_index" struct is actually designed as a singly linked list, and if a MIDX file has been already opened successfully, then the other MIDX files will be skipped and left with a warning "ignoring extra bitmap file." to the output. The discussion link of community: https://public-inbox.org/git/YjzCTLLDCby+kJrZ@nand.local/ Helped-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Teng Long <dyroneteng@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Teng Long committed Jul 19, 2022 at 00:46 UTC 5dcee7c7059307ca3a9d5c1a5c6551deb25cc3dc

1 file changed +3 -2

pack-bitmap.c

+3 -2

@@ -506,15 +506,16 @@ static int open_pack_bitmap(struct repository *r,

506 static int open_midx_bitmap(struct repository *r,

507 struct bitmap_index *bitmap_git)

508 {

509 + int ret = -1;

510 struct multi_pack_index *midx;

511

512 assert(!bitmap_git->map);

513

514 for (midx = get_multi_pack_index(r); midx; midx = midx->next) {

515 if (!open_midx_bitmap_1(bitmap_git, midx))

515 - return 0;

516 + ret = 0;

517 }

517 - return -1;

518 + return ret;

519 }

520

521 static int open_bitmap(struct repository *r,