terminal: seek when switching between reading and writing
When a stdio stream is opened in update mode (e.g., "w+"), the C standard forbids switching between reading or writing without an intervening positioning function. Many implementations are lenient about this, but Solaris libc will flush the recently-read contents to the output buffer. In this instance, that meant writing the non-echoed password that the user just typed to the terminal. Fix it by inserting a no-op fseek between the read and write. The opposite direction (writing followed by reading) is also disallowed, but our intervening fflush is an acceptable positioning function for that alternative. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jeff King committed
Aug 7, 2012 at 00:10 UTC
67ba123fd1fcb9a7699ae85f05f1229513322c1c
1 file changed
+1
compat/terminal.c
+1
@@ -59,6 +59,7 @@ char *git_terminal_prompt(const char *prompt, int echo)
59
60
r = strbuf_getline(&buf, fh, '\n');
61
if (!echo) {
62
+ fseek(fh, SEEK_CUR, 0);
63
putc('\n', fh);
64
fflush(fh);
65
}