fsck: make fsck_tag() warn-friendly
When fsck_tag() identifies a problem with the commit, it should try to make it possible to continue checking the commit object, in case the user wants to demote the detected errors to mere warnings. Just like fsck_commit(), there are certain problems that could hide other issues with the same tag object. For example, if the 'type' line is not encountered in the correct position, the 'tag' line – if there is any – would not be handled at all. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Johannes Schindelin committed
Jun 22, 2015 at 17:26 UTC
7d7d5b0568e49d9d0dd3b4909572fadca8fc3b06
1 file changed
+2
-1
fsck.c
+2
-1
@@ -643,7 +643,8 @@ static int fsck_tag_buffer(struct tag *tag, const char *data,
643
}
644
if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') {
645
ret = report(options, &tag->object, FSCK_MSG_BAD_OBJECT_SHA1, "invalid 'object' line format - bad sha1");
646
- goto done;
646
+ if (ret)
647
+ goto done;
648
}
649
buffer += 41;
650