remove unnecessary parameter from get_patch_ids()
get_patch_ids() takes an already initialized rev_info and a prefix. The prefix is used when initalizing a second rev_info. Since the initialized rev_info already has a prefix and the prefix never changes, we can use the prefix from the initialized rev_info to initialize the second rev_info. Signed-off-by: Martin von Zweigbergk <martin.von.zweigbergk@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Martin von Zweigbergk committed
Jul 27, 2012 at 10:21 UTC
811929f1695ed7de15cad14b9335534af672b472
1 file changed
+4
-4
builtin/log.c
+4
-4
@@ -696,7 +696,7 @@ static int reopen_stdout(struct commit *commit, const char *subject,
696
return 0;
697
}
698
699
-static void get_patch_ids(struct rev_info *rev, struct patch_ids *ids, const char *prefix)
699
+static void get_patch_ids(struct rev_info *rev, struct patch_ids *ids)
700
{
701
struct rev_info check_rev;
702
struct commit *commit;
@@ -717,7 +717,7 @@ static void get_patch_ids(struct rev_info *rev, struct patch_ids *ids, const cha
717
init_patch_ids(ids);
718
719
/* given a range a..b get all patch ids for b..a */
720
- init_revisions(&check_rev, prefix);
720
+ init_revisions(&check_rev, rev->prefix);
721
o1->flags ^= UNINTERESTING;
722
o2->flags ^= UNINTERESTING;
723
add_pending_object(&check_rev, o1, "o1");
@@ -1306,7 +1306,7 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
1306
if (hashcmp(o[0].item->sha1, o[1].item->sha1) == 0)
1307
return 0;
1308
}
1309
- get_patch_ids(&rev, &ids, prefix);
1309
+ get_patch_ids(&rev, &ids);
1310
}
1311
1312
if (!use_stdout)
@@ -1525,7 +1525,7 @@ int cmd_cherry(int argc, const char **argv, const char *prefix)
1525
return 0;
1526
}
1527
1528
- get_patch_ids(&revs, &ids, prefix);
1528
+ get_patch_ids(&revs, &ids);
1529
1530
if (limit && add_pending_commit(limit, &revs, UNINTERESTING))
1531
die(_("Unknown commit %s"), limit);