enable "no-done" extension only when fetching over smart-http
When 'no-done' protocol extension is used, the upload-pack (i.e. the server side) process stops listening to the fetch-pack after issuing the final NAK, and starts sending the generated pack data back, but there may be more "have" send by the latter in flight that the fetch-pack is expecting to be responded with ACK/NAK. This will typically result in a deadlock (both will block on write that the other end never reads) or SIGPIPE on the fetch-pack end (upload-pack will finish writing a small pack and goes away). Disable it unless fetch-pack is running under smart-http, where there is no such streaming issue. Signed-off-by: Junio C Hamano <gitster@pobox.com> Acked-by: Shawn O. Pearce <spearce@spearce.org>
Junio C Hamano committed
Mar 29, 2011 at 10:16 UTC
8e9182e09127b20b8d8ce19655037991feac798d
1 file changed
+2
-1
builtin/fetch-pack.c
+2
-1
@@ -708,7 +708,8 @@ static struct ref *do_fetch_pack(int fd[2],
708
if (server_supports("no-done")) {
709
if (args.verbose)
710
fprintf(stderr, "Server supports no-done\n");
711
- no_done = 1;
711
+ if (args.stateless_rpc)
712
+ no_done = 1;
713
}
714
}
715
else if (server_supports("multi_ack")) {