test-lib: unset trace2 parent envvars

The trace2 subsystem can inherit certain information from parent processes via environment variables; e.g., the parent command name and session ID. This allows trace2 to note when a command is the child process of another Git process, and to adjust various pieces of output accordingly. This behavior breaks certain tests that examine trace2 output when the tests run as a child of another git process, such as in `git rebase -x "make test"`. While we could fix this by unsetting the relevant variables in the affected tests (currently t0210, t0211, t0212, and t6421), this would leave other tests vulnerable to similar breakage if new test cases are added which inspect trace2 output. So fix this in general by unsetting GIT_TRACE2_PARENT_NAME and GIT_TRACE2_PARENT_SID in test-lib.sh. Reported-by: Emily Shaffer <emilyshaffer@google.com> Helped-by: Jonathan Tan <jonathantanmy@google.com> Signed-off-by: Josh Steadmon <steadmon@google.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Josh Steadmon committed Jan 13, 2022 at 19:33 UTC 944d808e42817d48bea480c135bc9d3efd53d4e7
1 file changed +2
t/test-lib.sh
+2
@@ -449,6 +449,8 @@ unset VISUAL EMAIL LANGUAGE $("$PERL_PATH" -e '
449 unset XDG_CACHE_HOME
450 unset XDG_CONFIG_HOME
451 unset GITPERLLIB
452 +unset GIT_TRACE2_PARENT_NAME
453 +unset GIT_TRACE2_PARENT_SID
454 TEST_AUTHOR_LOCALNAME=author
455 TEST_AUTHOR_DOMAIN=example.com
456 GIT_AUTHOR_EMAIL=${TEST_AUTHOR_LOCALNAME}@${TEST_AUTHOR_DOMAIN}