git-prompt.sh: localize `option` in __git_ps1_show_upstream
The variable 'option' is used in __git_ps1_show_upstream() without being localized. This clobbers the variable the user may be using for other purposes, which is bad. Luckily, $option is not used to carry information around in the script as a global variable. The use of it in this script has very limited scope (namely, only inside this function), so just declare that it is "local". Signed-off-by: Sibo Dong <sibo.dong@outlook.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Sibo Dong committed
Oct 31, 2020 at 22:09 UTC
9542d56379b60bb97d17ae1d1c8e8e4bc1fd65a3
1 file changed
+1
contrib/completion/git-prompt.sh
+1
@@ -137,6 +137,7 @@ __git_ps1_show_upstream ()
137
done <<< "$output"
138
139
# parse configuration values
140
+ local option
141
for option in ${GIT_PS1_SHOWUPSTREAM}; do
142
case "$option" in
143
git|svn) upstream="$option" ;;