check-ref-format: fix trivial memory leak
Fix a memory leak in "git check-ref-format" that's been present in the code in one form or another since 38eedc634bc (git check-ref-format --print, 2009-10-12), the code got substantially refactored in cfbe22f03f9 (check-ref-format: handle subcommands in separate functions, 2010-08-05). As a result we can mark a test as passing with SANITIZE=leak using "TEST_PASSES_SANITIZE_LEAK=true". Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Jul 1, 2022 at 12:42 UTC
99b6c45d8f846ed055ba814d985084733d36dabc
2 files changed
+9
-3
builtin/check-ref-format.c
+8
-3
@@ -57,6 +57,8 @@ int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
57
int normalize = 0;
58
int flags = 0;
59
const char *refname;
60
+ char *to_free = NULL;
61
+ int ret = 1;
62
63
if (argc == 2 && !strcmp(argv[1], "-h"))
64
usage(builtin_check_ref_format_usage);
@@ -81,11 +83,14 @@ int cmd_check_ref_format(int argc, const char **argv, const char *prefix)
83
84
refname = argv[i];
85
if (normalize)
84
- refname = collapse_slashes(refname);
86
+ refname = to_free = collapse_slashes(refname);
87
if (check_refname_format(refname, flags))
86
- return 1;
88
+ goto cleanup;
89
if (normalize)
90
printf("%s\n", refname);
91
90
- return 0;
92
+ ret = 0;
93
+cleanup:
94
+ free(to_free);
95
+ return ret;
96
}
t/t1402-check-ref-format.sh
+1
@@ -2,6 +2,7 @@
2
3
test_description='Test git check-ref-format'
4
5
+TEST_PASSES_SANITIZE_LEAK=true
6
. ./test-lib.sh
7
8
valid_ref() {