@matheusbsbs / matheus-bagliano / commits / cb2912c324

link_alt_odb_entry: fix read over array bounds reported by valgrind

pfxlen can be longer than the path in objdir when relative_base contains the path to gits object directory. Here we are interested in checking if ent->base[] (the part that corresponds to .git/objects) is the same string as objdir, and the code NUL-terminated ent->base[] to LEADING PATH\0XX/XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX\0 in preparation for these "duplicate check" step (before we return from the function, the first NUL is turned into '/' so that we can fill XX when probing for loose objects). All we need to do is to compare the string with the path to our object directory. Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Heiko Voigt committed Jul 28, 2012 at 17:46 UTC cb2912c324477f0d92618ac258c43b2692e870c4

1 file changed +1 -1

sha1_file.c

+1 -1

@@ -298,7 +298,7 @@ static int link_alt_odb_entry(const char * entry, int len, const char * relative

298 return -1;

299 }

300 }

301 - if (!memcmp(ent->base, objdir, pfxlen)) {

301 + if (!strcmp(ent->base, objdir)) {

302 free(ent);

303 return -1;

304 }