commit-reach: plug minor memory leak after using is_descendant_of()

ref_newer() builds a commit_list to pass a single potential ancestor to is_descendant_of(). The latter leaves the list intact. Release the allocated memory after the call. Signed-off-by: René Scharfe <l.s.r@web.de> Acked-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

René Scharfe committed Jun 19, 2020 at 15:13 UTC d546fe2874ce8dc73cb0ac7541640fd202ec27c8

1 file changed +4 -1

commit-reach.c

+4 -1

@@ -396,6 +396,7 @@ int ref_newer(const struct object_id *new_oid, const struct object_id *old_oid)

396 struct object *o;

397 struct commit *old_commit, *new_commit;

398 struct commit_list *old_commit_list = NULL;

399 + int ret;

400

401 /*

402 * Both new_commit and old_commit must be commit-ish and new_commit is descendant of

@@ -417,7 +418,9 @@ int ref_newer(const struct object_id *new_oid, const struct object_id *old_oid)

418 return 0;

419

420 commit_list_insert(old_commit, &old_commit_list);

420 - return is_descendant_of(new_commit, old_commit_list);

421 + ret = is_descendant_of(new_commit, old_commit_list);

422 + free_commit_list(old_commit_list);

423 + return ret;

424 }

425

426 /*