@matheusbsbs / matheus-bagliano / commits / e0f7ae564e
Fork 0

submodule: eliminate unused parameters from print_submodule_summary()

Eliminate the parameters 'missing_{src,dst}' from the 'print_submodule_summary()' function call since they are not used anywhere in the function. Reported-by: Jeff King <peff@peff.net> Mentored-by: Christian Couder <chriscool@tuxfamily.org> Mentored-by: Kaartic Sivaraam <kaartic.sivaraam@gmail.com> Signed-off-by: Shourya Shukla <shouryashukla.oo@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Shourya Shukla committed Aug 25, 2020 at 17:00 UTC e0f7ae564eecd5e43704c9640ea68ff93a8f316e
1 file changed +1 -3
builtin/submodule--helper.c
+1 -3
@@ -982,7 +982,6 @@ static char* verify_submodule_committish(const char *sm_path,
982 static void print_submodule_summary(struct summary_cb *info, char* errmsg,
983 int total_commits, const char *displaypath,
984 const char *src_abbrev, const char *dst_abbrev,
985 - int missing_src, int missing_dst,
985 struct module_cb *p)
986 {
987 if (p->status == 'T') {
@@ -1154,8 +1153,7 @@ static void generate_submodule_summary(struct summary_cb *info,
1153
1154 print_submodule_summary(info, errmsg, total_commits,
1155 displaypath, src_abbrev,
1157 - dst_abbrev, missing_src,
1158 - missing_dst, p);
1156 + dst_abbrev, p);
1157
1158 free(displaypath);
1159 free(src_abbrev);