@matheusbsbs / matheus-bagliano / commits / e8e5195573

tests: paint known breakages in yellow

Yellow seems a more appropriate color than bold green when considering the universal traffic lights coloring scheme, where green conveys the impression that everything's OK, and amber that something's not quite right. Likewise, change the color of the summarized total number of known breakages from bold red to the same yellow to be less alarmist and more consistent with the above. An earlier version of this patch used bold yellow but because these are all long-known failures, reminding them to developers in bold over and over does not help encouraging them to take a look at them very much. This iteration paints them in plain yellow instead to make them less distracting. Signed-off-by: Adam Spiers <git@adamspiers.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>

Adam Spiers committed Dec 16, 2012 at 18:28 UTC e8e5195573bc0f314ccc288f7d009b47e4440760

1 file changed +4 -2

t/test-lib.sh

+4 -2

@@ -183,6 +183,8 @@ then

183 tput bold; tput setaf 1;; # bold red

184 skip)

185 tput bold; tput setaf 2;; # bold green

186 + warn)

187 + tput setaf 3;; # brown/yellow

188 pass)

189 tput setaf 2;; # green

190 info)

@@ -281,7 +283,7 @@ test_known_broken_ok_ () {

283

284 test_known_broken_failure_ () {

285 test_broken=$(($test_broken+1))

284 - say_color skip "not ok $test_count - $@ # TODO known breakage"

286 + say_color warn "not ok $test_count - $@ # TODO known breakage"

287 }

288

289 test_debug () {

@@ -375,7 +377,7 @@ test_done () {

377 fi

378 if test "$test_broken" != 0

379 then

378 - say_color error "# still have $test_broken known breakage(s)"

380 + say_color warn "# still have $test_broken known breakage(s)"

381 msg="remaining $(($test_count-$test_broken)) test(s)"

382 else

383 msg="$test_count test(s)"