tests: make test_expect_code quieter on success
A command exiting with the expected status is not particularly notable. While the indication of progress might be useful when tracking down where in a test a failure has happened, the same applies to most other test helpers, which are quiet about success, so this single helper's output stands out in an unpleasant way. An alternative method for showing progress information might to invent a --progress option that runs tests with "set -x", or until that is available, to run tests using commands like prove -v -j2 --shuffle --exec='sh -x' t2202-add-addremove.sh Signed-off-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Jonathan Nieder committed
May 21, 2011 at 14:40 UTC
f5b7ce1b9041d19658b79d8b956d7e79ec6006bd
1 file changed
+3
-4
t/test-lib.sh
+3
-4
@@ -731,12 +731,11 @@ test_expect_code () {
731
exit_code=$?
732
if test $exit_code = $want_code
733
then
734
- echo >&2 "test_expect_code: command exited with $exit_code: $*"
734
return 0
736
- else
737
- echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
738
- return 1
735
fi
736
+
737
+ echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
738
+ return 1
739
}
740
741
# test_cmp is a helper function to compare actual and expected output.