remote-mediawiki tests: annotate failing tests
These tests consistently fail for me, and were failing before any of the changes in this series. As noted in [1] there are some known intermittent test failures. Let's mark these as failing so we can have an otherwise passing test suite. We need to add an extra test_path_is_file() here because since d572f52a64 ("test_cmp: diagnose incorrect arguments", 2020-08-09) test_cmp has errored out with a BUG if one of the test arguments doesn't exist, without that the test would still fail even without test_expect_failure(). 1. https://github.com/Git-Mediawiki/Git-Mediawiki/issues/56 Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Ævar Arnfjörð Bjarmason committed
Sep 21, 2020 at 12:39 UTC
f8ab018dafc2ecbea29397c2112c9e7156d7f080
1 file changed
+3
-2
contrib/mw-to-git/t/t9363-mw-to-git-export-import.sh
+3
-2
@@ -32,7 +32,7 @@ test_expect_success 'setup config' '
32
test_might_fail git config --global --unset remote.origin.mediaImport
33
'
34
35
-test_expect_success 'git push can upload media (File:) files' '
35
+test_expect_failure 'git push can upload media (File:) files' '
36
wiki_reset &&
37
git clone mediawiki::'"$WIKI_URL"' mw_dir &&
38
(
@@ -48,13 +48,14 @@ test_expect_success 'git push can upload media (File:) files' '
48
)
49
'
50
51
-test_expect_success 'git clone works on previously created wiki with media files' '
51
+test_expect_failure 'git clone works on previously created wiki with media files' '
52
test_when_finished "rm -rf mw_dir mw_dir_clone" &&
53
git clone -c remote.origin.mediaimport=true \
54
mediawiki::'"$WIKI_URL"' mw_dir_clone &&
55
test_cmp mw_dir_clone/Foo.txt mw_dir/Foo.txt &&
56
(cd mw_dir_clone && git checkout HEAD^) &&
57
(cd mw_dir && git checkout HEAD^) &&
58
+ test_path_is_file mw_dir_clone/Foo.txt &&
59
test_cmp mw_dir_clone/Foo.txt mw_dir/Foo.txt
60
'
61