for-each-ref: clean up code
In 'grab_single_ref()' remove the extra count variable 'cnt' and use the variable 'grab_cnt' of structure 'grab_ref_cbdata' directly instead. Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr> Signed-off-by: Karthik Nayak <karthik.188@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Karthik Nayak committed
Jun 14, 2015 at 01:07 UTC
fc80edcae1cdaac42b2e09c64df2e5cd06e3a336
1 file changed
+2
-5
builtin/for-each-ref.c
+2
-5
@@ -897,7 +897,6 @@ static int grab_single_ref(const char *refname, const struct object_id *oid,
897
{
898
struct grab_ref_cbdata *cb = cb_data;
899
struct refinfo *ref;
900
- int cnt;
900
901
if (flag & REF_BAD_NAME) {
902
warning("ignoring ref with broken name %s", refname);
@@ -914,10 +913,8 @@ static int grab_single_ref(const char *refname, const struct object_id *oid,
913
*/
914
ref = new_refinfo(refname, oid->hash, flag);
915
917
- cnt = cb->grab_cnt;
918
- REALLOC_ARRAY(cb->grab_array, cnt + 1);
919
- cb->grab_array[cnt++] = ref;
920
- cb->grab_cnt = cnt;
916
+ REALLOC_ARRAY(cb->grab_array, cb->grab_cnt + 1);
917
+ cb->grab_array[cb->grab_cnt++] = ref;
918
return 0;
919
}
920