Flow upgrade to 0.143
This was a large upgrade that removed "classic mode" and made "types first" the only option. Most of the needed changes have been done in previous PRs, this just fixes up the last few instances. ghstack-source-id: 9612d95ba4b32edeb73fee8be9f3d67c43e86b80 Pull Request resolved: https://github.com/facebook/react/pull/25408
Jan Kassens committed
Oct 4, 2022 at 10:50 UTC
00a2f81508cccd59556e1bea0208726f9dbfbfa9
9 files changed
+27
-31
package.json
+1
-1
@@ -63,7 +63,7 @@
63
"eslint-plugin-react-internal": "link:./scripts/eslint-rules",
64
"fbjs-scripts": "1.2.0",
65
"filesize": "^6.0.1",
66
- "flow-bin": "^0.142.0",
66
+ "flow-bin": "^0.143.0",
67
"glob": "^7.1.6",
68
"glob-stream": "^6.1.0",
69
"google-closure-compiler": "^20200517.0.0",
packages/react-dom/src/server/ReactDOMFizzServerBrowser.js
+2
-2
@@ -57,10 +57,10 @@ function renderToReadableStream(
57
const stream: ReactDOMServerReadableStream = (new ReadableStream(
58
{
59
type: 'bytes',
60
- pull(controller): ?Promise<void> {
60
+ pull: (controller): ?Promise<void> => {
61
startFlowing(request, controller);
62
},
63
- cancel(reason): ?Promise<void> {
63
+ cancel: (reason): ?Promise<void> => {
64
abort(request);
65
},
66
},
packages/react-dom/src/server/ReactDOMFizzStaticBrowser.js
+1
-1
@@ -50,7 +50,7 @@ function prerender(
50
const stream = new ReadableStream(
51
{
52
type: 'bytes',
53
- pull(controller): ?Promise<void> {
53
+ pull: (controller): ?Promise<void> => {
54
startFlowing(request, controller);
55
},
56
},
packages/react-reconciler/src/ReactStrictModeWarnings.new.js
+5
-5
@@ -20,11 +20,11 @@ type FiberArray = Array<Fiber>;
20
type FiberToFiberComponentsMap = Map<Fiber, FiberArray>;
21
22
const ReactStrictModeWarnings = {
23
- recordUnsafeLifecycleWarnings(fiber: Fiber, instance: any): void {},
24
- flushPendingUnsafeLifecycleWarnings(): void {},
25
- recordLegacyContextWarning(fiber: Fiber, instance: any): void {},
26
- flushLegacyContextWarning(): void {},
27
- discardPendingWarnings(): void {},
23
+ recordUnsafeLifecycleWarnings: (fiber: Fiber, instance: any): void => {},
24
+ flushPendingUnsafeLifecycleWarnings: (): void => {},
25
+ recordLegacyContextWarning: (fiber: Fiber, instance: any): void => {},
26
+ flushLegacyContextWarning: (): void => {},
27
+ discardPendingWarnings: (): void => {},
28
};
29
30
if (__DEV__) {
packages/react-reconciler/src/ReactStrictModeWarnings.old.js
+5
-5
@@ -20,11 +20,11 @@ type FiberArray = Array<Fiber>;
20
type FiberToFiberComponentsMap = Map<Fiber, FiberArray>;
21
22
const ReactStrictModeWarnings = {
23
- recordUnsafeLifecycleWarnings(fiber: Fiber, instance: any): void {},
24
- flushPendingUnsafeLifecycleWarnings(): void {},
25
- recordLegacyContextWarning(fiber: Fiber, instance: any): void {},
26
- flushLegacyContextWarning(): void {},
27
- discardPendingWarnings(): void {},
23
+ recordUnsafeLifecycleWarnings: (fiber: Fiber, instance: any): void => {},
24
+ flushPendingUnsafeLifecycleWarnings: (): void => {},
25
+ recordLegacyContextWarning: (fiber: Fiber, instance: any): void => {},
26
+ flushLegacyContextWarning: (): void => {},
27
+ discardPendingWarnings: (): void => {},
28
};
29
30
if (__DEV__) {
packages/react-refresh/src/ReactFreshRuntime.js
+5
-7
@@ -460,20 +460,18 @@ export function injectIntoGlobalHook(globalObject: any): void {
460
globalObject.__REACT_DEVTOOLS_GLOBAL_HOOK__ = hook = {
461
renderers: new Map(),
462
supportsFiber: true,
463
- inject(injected) {
464
- return nextID++;
465
- },
466
- onScheduleFiberRoot(
463
+ inject: injected => nextID++,
464
+ onScheduleFiberRoot: (
465
id: number,
466
root: FiberRoot,
467
children: ReactNodeList,
470
- ) {},
471
- onCommitFiberRoot(
468
+ ) => {},
469
+ onCommitFiberRoot: (
470
id: number,
471
root: FiberRoot,
472
maybePriorityLevel: mixed,
473
didError: boolean,
476
- ) {},
474
+ ) => {},
475
onCommitFiberUnmount() {},
476
};
477
}
packages/react-server-dom-webpack/src/ReactFlightDOMServerBrowser.js
+3
-3
@@ -52,13 +52,13 @@ function renderToReadableStream(
52
const stream = new ReadableStream(
53
{
54
type: 'bytes',
55
- start(controller): ?Promise<void> {
55
+ start: (controller): ?Promise<void> => {
56
startWork(request);
57
},
58
- pull(controller): ?Promise<void> {
58
+ pull: (controller): ?Promise<void> => {
59
startFlowing(request, controller);
60
},
61
- cancel(reason): ?Promise<void> {},
61
+ cancel: (reason): ?Promise<void> => {},
62
},
63
// $FlowFixMe size() methods are not allowed on byte streams.
64
{highWaterMark: 0},
scripts/flow/config/flowconfig
+1
-3
@@ -45,11 +45,9 @@ esproposal.class_instance_fields=enable
45
esproposal.optional_chaining=enable
46
exact_by_default=true
47
munge_underscores=false
48
-types_first=true
49
-well_formed_exports=true
48
49
# Substituted by createFlowConfig.js:
50
%REACT_RENDERER_FLOW_OPTIONS%
51
52
[version]
55
-^0.142.0
53
+^0.143.0
yarn.lock
+4
-4
@@ -7911,10 +7911,10 @@ flatted@^2.0.0:
7911
resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138"
7912
integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA==
7913
7914
-flow-bin@^0.142.0:
7915
- version "0.142.0"
7916
- resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.142.0.tgz#b46b69de1123cf7c5a50917402968e07291df054"
7917
- integrity sha512-YgiapK/wrJjcgSgOWfoncbZ4vZrZWdHs+p7V9duI9zo4ehW2nM/VRrpSaWoZ+CWu3t+duGyAvupJvC6MM2l07w==
7914
+flow-bin@^0.143.0:
7915
+ version "0.143.1"
7916
+ resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.143.1.tgz#2ff825dfd85e84531b0ae780842cb1c2a9743cd2"
7917
+ integrity sha512-6S6bgZ/pghBzEUELXkwFH/bsHT+GBMo8ftHDYs0SSJ+1e6NRdFfqxcYhaTvAK8zteSfQLZBIoec6G4WPPp4qQg==
7918
7919
fluent-syntax@0.13.0:
7920
version "0.13.0"