v1.6.9
Code Review finds its own comment threads
siGit Code Review follows up on its findings — but on
GitHub it couldn't find the threads it owned. The reviewer was reading review comments from
/reviews/{id}/comments, an endpoint that returns comments without line anchors (line and
original_line come back null), so no stored finding could be matched to its thread. Every
follow-up silently found nothing.
The fix
The reviewer now reads from /pulls/{n}/comments, which returns the line anchors it needs.
A new pull_request_comments method fetches root and reply comments together, and the
stored external_id is now populated when a finding is first posted, so follow-ups can find
the thread directly instead of re-scanning.
Backfill
Findings posted before this fix were stored without their comment id. A one-off rake task
(code_review:backfill_comment_ids) walks recent completed reviews, matches findings to
their comments by path and line, and writes the missing ids back.
Release masters: @setoelkahfi and @sigit.