Clean up vestige of useOpaqueIdentifier (#25587)
Found some code that was left over from the experimental useOpaqueIdentifier hook, which we eventually replaced with useId. This deletes it.
Andrew Clark committed
Oct 29, 2022 at 17:46 UTC
2ac77aab94d125942d71e9113d70253eaaef698f
4 files changed
+2
-28
packages/react-reconciler/src/ReactFiberHooks.new.js
-9
@@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
767
hookTypesUpdateIndexDev = -1;
768
769
currentHookNameInDev = null;
770
-
771
- isUpdatingOpaqueValueInRenderPhase = false;
770
}
771
772
didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
2378
return [isPending, start];
2379
}
2380
2383
-let isUpdatingOpaqueValueInRenderPhase = false;
2384
-export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
2385
- if (__DEV__) {
2386
- return isUpdatingOpaqueValueInRenderPhase;
2387
- }
2388
-}
2389
-
2381
function mountId(): string {
2382
const hook = mountWorkInProgressHook();
2383
packages/react-reconciler/src/ReactFiberHooks.old.js
-9
@@ -767,8 +767,6 @@ export function resetHooksAfterThrow(): void {
767
hookTypesUpdateIndexDev = -1;
768
769
currentHookNameInDev = null;
770
-
771
- isUpdatingOpaqueValueInRenderPhase = false;
770
}
771
772
didScheduleRenderPhaseUpdateDuringThisPass = false;
@@ -2380,13 +2378,6 @@ function rerenderTransition(): [
2378
return [isPending, start];
2379
}
2380
2383
-let isUpdatingOpaqueValueInRenderPhase = false;
2384
-export function getIsUpdatingOpaqueValueInRenderPhaseInDEV(): boolean | void {
2385
- if (__DEV__) {
2386
- return isUpdatingOpaqueValueInRenderPhase;
2387
- }
2388
-}
2389
-
2381
function mountId(): string {
2382
const hook = mountWorkInProgressHook();
2383
packages/react-reconciler/src/ReactFiberWorkLoop.new.js
+1
-5
@@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.new';
205
import {
206
resetHooksAfterThrow,
207
ContextOnlyDispatcher,
208
- getIsUpdatingOpaqueValueInRenderPhaseInDEV,
208
} from './ReactFiberHooks.new';
209
import {DefaultCacheDispatcher} from './ReactFiberCache.new';
210
import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
3637
3638
function warnAboutRenderPhaseUpdatesInDEV(fiber) {
3639
if (__DEV__) {
3641
- if (
3642
- ReactCurrentDebugFiberIsRenderingInDEV &&
3643
- !getIsUpdatingOpaqueValueInRenderPhaseInDEV()
3644
- ) {
3640
+ if (ReactCurrentDebugFiberIsRenderingInDEV) {
3641
switch (fiber.tag) {
3642
case FunctionComponent:
3643
case ForwardRef:
packages/react-reconciler/src/ReactFiberWorkLoop.old.js
+1
-5
@@ -205,7 +205,6 @@ import {resetContextDependencies} from './ReactFiberNewContext.old';
205
import {
206
resetHooksAfterThrow,
207
ContextOnlyDispatcher,
208
- getIsUpdatingOpaqueValueInRenderPhaseInDEV,
208
} from './ReactFiberHooks.old';
209
import {DefaultCacheDispatcher} from './ReactFiberCache.old';
210
import {
@@ -3638,10 +3637,7 @@ if (__DEV__) {
3637
3638
function warnAboutRenderPhaseUpdatesInDEV(fiber) {
3639
if (__DEV__) {
3641
- if (
3642
- ReactCurrentDebugFiberIsRenderingInDEV &&
3643
- !getIsUpdatingOpaqueValueInRenderPhaseInDEV()
3644
- ) {
3640
+ if (ReactCurrentDebugFiberIsRenderingInDEV) {
3641
switch (fiber.tag) {
3642
case FunctionComponent:
3643
case ForwardRef: