remove RTR from ReactCacheOld-test (#28409)
## Summary swaps `react-test-renderer` for `react-noop-rendererer` in ReactCacheOld-test ## How did you test this change? `yarn test-www ReactCacheOld`
Noah Lemen committed
Feb 21, 2024 at 13:31 UTC
41b3c31bcbe9f238697b4c79b39017916e0f131c
1 file changed
+18
-31
packages/react-cache/src/__tests__/ReactCacheOld-test.internal.js
+18
-31
@@ -13,7 +13,7 @@ let ReactCache;
13
let createResource;
14
let React;
15
let ReactFeatureFlags;
16
-let ReactTestRenderer;
16
+let ReactNoop;
17
let Scheduler;
18
let Suspense;
19
let TextResource;
@@ -34,7 +34,7 @@ describe('ReactCache', () => {
34
Suspense = React.Suspense;
35
ReactCache = require('react-cache');
36
createResource = ReactCache.unstable_createResource;
37
- ReactTestRenderer = require('react-test-renderer');
37
+ ReactNoop = require('react-noop-renderer');
38
Scheduler = require('scheduler');
39
40
const InternalTestUtils = require('internal-test-utils');
@@ -120,9 +120,8 @@ describe('ReactCache', () => {
120
);
121
}
122
123
- ReactTestRenderer.create(<App />, {
124
- isConcurrent: true,
125
- });
123
+ const root = ReactNoop.createRoot();
124
+ root.render(<App />);
125
126
await waitForAll(['Suspend! [Hi]', 'Loading...']);
127
@@ -140,9 +139,8 @@ describe('ReactCache', () => {
139
);
140
}
141
143
- const root = ReactTestRenderer.create(<App />, {
144
- isConcurrent: true,
145
- });
142
+ const root = ReactNoop.createRoot();
143
+ root.render(<App />);
144
145
await waitForAll(['Suspend! [Hi]', 'Loading...']);
146
@@ -157,7 +155,7 @@ describe('ReactCache', () => {
155
assertLog(['Promise rejected [Hi]', 'Error! [Hi]', 'Error! [Hi]']);
156
157
// Should throw again on a subsequent read
160
- root.update(<App />);
158
+ root.render(<App />);
159
await waitForThrow('Failed to load: Hi');
160
assertLog(['Error! [Hi]', 'Error! [Hi]']);
161
});
@@ -176,13 +174,11 @@ describe('ReactCache', () => {
174
return BadTextResource.read(['Hi', 100]);
175
}
176
179
- ReactTestRenderer.create(
177
+ const root = ReactNoop.createRoot();
178
+ root.render(
179
<Suspense fallback={<Text text="Loading..." />}>
180
<App />
181
</Suspense>,
183
- {
184
- isConcurrent: true,
185
- },
182
);
183
184
if (__DEV__) {
@@ -202,16 +198,14 @@ describe('ReactCache', () => {
198
it('evicts least recently used values', async () => {
199
ReactCache.unstable_setGlobalCacheLimit(3);
200
201
+ const root = ReactNoop.createRoot();
202
// Render 1, 2, and 3
206
- const root = ReactTestRenderer.create(
203
+ root.render(
204
<Suspense fallback={<Text text="Loading..." />}>
205
<AsyncText ms={100} text={1} />
206
<AsyncText ms={100} text={2} />
207
<AsyncText ms={100} text={3} />
208
</Suspense>,
212
- {
213
- isConcurrent: true,
214
- },
209
);
210
await waitForAll(['Suspend! [1]', 'Loading...']);
211
jest.advanceTimersByTime(100);
@@ -228,7 +222,7 @@ describe('ReactCache', () => {
222
expect(root).toMatchRenderedOutput('123');
223
224
// Render 1, 4, 5
231
- root.update(
225
+ root.render(
226
<Suspense fallback={<Text text="Loading..." />}>
227
<AsyncText ms={100} text={1} />
228
<AsyncText ms={100} text={4} />
@@ -255,7 +249,7 @@ describe('ReactCache', () => {
249
// We've now rendered values 1, 2, 3, 4, 5, over our limit of 3. The least
250
// recently used values are 2 and 3. They should have been evicted.
251
258
- root.update(
252
+ root.render(
253
<Suspense fallback={<Text text="Loading..." />}>
254
<AsyncText ms={100} text={1} />
255
<AsyncText ms={100} text={2} />
@@ -293,13 +287,11 @@ describe('ReactCache', () => {
287
return <Text text="Result" />;
288
}
289
296
- const root = ReactTestRenderer.create(
290
+ const root = ReactNoop.createRoot();
291
+ root.render(
292
<Suspense fallback={<Text text="Loading..." />}>
293
<App />
294
</Suspense>,
300
- {
301
- isConcurrent: true,
302
- },
295
);
296
297
await waitForAll(['Loading...']);
@@ -351,13 +343,11 @@ describe('ReactCache', () => {
343
}
344
}
345
354
- const root = ReactTestRenderer.create(
346
+ const root = ReactNoop.createRoot();
347
+ root.render(
348
<Suspense fallback={<Text text="Loading..." />}>
349
<BadAsyncText text="Hi" />
350
</Suspense>,
358
- {
359
- isConcurrent: true,
360
- },
351
);
352
353
await waitForAll(['Suspend! [Hi]', 'Loading...']);
@@ -367,13 +357,10 @@ describe('ReactCache', () => {
357
// cached value.
358
resolveThenable('Hi muahahaha I am different');
359
370
- root.update(
360
+ root.render(
361
<Suspense fallback={<Text text="Loading..." />}>
362
<BadAsyncText text="Hi" />
363
</Suspense>,
374
- {
375
- isConcurrent: true,
376
- },
364
);
365
366
assertLog([]);