Remove excess `ms` prop from Suspense tests (#28566)
Sebastian Silbermann committed
Mar 15, 2024 at 20:57 UTC
4d85c666a3e0c433453a73bdb78ee9cbdfb3fc82
5 files changed
+69
-77
packages/react-reconciler/src/__tests__/ReactSuspense-test.internal.js
+22
-22
@@ -107,7 +107,7 @@ describe('ReactSuspense', () => {
107
<Suspense fallback={<Text text="Loading..." />}>
108
{renderBar ? (
109
<Bar>
110
- <AsyncText text="A" ms={100} />
110
+ <AsyncText text="A" />
111
<Text text="B" />
112
</Bar>
113
) : null}
@@ -153,10 +153,10 @@ describe('ReactSuspense', () => {
153
root.render(
154
<>
155
<Suspense fallback={<Text text="Loading A..." />}>
156
- <AsyncText text="A" ms={5000} />
156
+ <AsyncText text="A" />
157
</Suspense>
158
<Suspense fallback={<Text text="Loading B..." />}>
159
- <AsyncText text="B" ms={6000} />
159
+ <AsyncText text="B" />
160
</Suspense>
161
</>,
162
);
@@ -258,9 +258,9 @@ describe('ReactSuspense', () => {
258
Scheduler.log('Foo');
259
return (
260
<Suspense fallback={<Text text="Loading..." />}>
261
- <AsyncText text="A" ms={200} />
261
+ <AsyncText text="A" />
262
<Suspense fallback={<Text text="Loading more..." />}>
263
- <AsyncText text="B" ms={300} />
263
+ <AsyncText text="B" />
264
</Suspense>
265
</Suspense>
266
);
@@ -294,9 +294,9 @@ describe('ReactSuspense', () => {
294
Scheduler.log('Foo');
295
return (
296
<Suspense fallback={<Text text="Loading..." />}>
297
- <AsyncText text="A" ms={200} />
297
+ <AsyncText text="A" />
298
<Suspense fallback={<Text text="Loading more..." />}>
299
- <AsyncText text="B" ms={1200} />
299
+ <AsyncText text="B" />
300
</Suspense>
301
</Suspense>
302
);
@@ -346,7 +346,7 @@ describe('ReactSuspense', () => {
346
<>
347
<Text text={`A${step}`} />
348
<Suspense fallback={<Text text="Loading..." />}>
349
- {shouldSuspend ? <AsyncText text="Async" ms={2000} /> : null}
349
+ {shouldSuspend ? <AsyncText text="Async" /> : null}
350
</Suspense>
351
<Text text={`B${step}`} />
352
<Text text={`C${step}`} />
@@ -627,7 +627,7 @@ describe('ReactSuspense', () => {
627
return (
628
<Suspense fallback={<Text text="Loading..." />}>
629
<TextWithLayout text="Child 1" />
630
- {show && <AsyncText ms={1000} text="Child 2" />}
630
+ {show && <AsyncText text="Child 2" />}
631
</Suspense>
632
);
633
}
@@ -722,7 +722,7 @@ describe('ReactSuspense', () => {
722
return (
723
<Suspense fallback={<TextWithLifecycle text="Loading..." />}>
724
<TextWithLifecycle text="A" />
725
- <AsyncTextWithLifecycle ms={100} text="B" ref={instance} />
725
+ <AsyncTextWithLifecycle text="B" ref={instance} />
726
<TextWithLifecycle text="C" />
727
</Suspense>
728
);
@@ -776,7 +776,7 @@ describe('ReactSuspense', () => {
776
return (
777
<Suspense fallback={<Text text="Loading..." />}>
778
<Stateful />
779
- <AsyncText ms={1000} text={props.text} />
779
+ <AsyncText text={props.text} />
780
</Suspense>
781
);
782
}
@@ -822,7 +822,7 @@ describe('ReactSuspense', () => {
822
<Indirection>
823
<Indirection>
824
<Indirection>
825
- <AsyncText ms={1000} text={props.text} />
825
+ <AsyncText text={props.text} />
826
</Indirection>
827
</Indirection>
828
</Indirection>
@@ -872,7 +872,7 @@ describe('ReactSuspense', () => {
872
function App({text}) {
873
return (
874
<Suspense fallback={<Text text="Loading..." />}>
875
- <AsyncTextWithUnmount text={text} ms={100} />
875
+ <AsyncTextWithUnmount text={text} />
876
</Suspense>
877
);
878
}
@@ -902,7 +902,7 @@ describe('ReactSuspense', () => {
902
function App({text}) {
903
return (
904
<Suspense fallback={<Text text="Loading..." />}>
905
- <AsyncTextWithEffect text={text} ms={100} />
905
+ <AsyncTextWithEffect text={text} />
906
</Suspense>
907
);
908
}
@@ -920,7 +920,7 @@ describe('ReactSuspense', () => {
920
state = {step: 1};
921
render() {
922
instance = this;
923
- return <AsyncText ms={1000} text={`Step: ${this.state.step}`} />;
923
+ return <AsyncText text={`Step: ${this.state.step}`} />;
924
}
925
}
926
@@ -976,9 +976,9 @@ describe('ReactSuspense', () => {
976
function App(props) {
977
return (
978
<Suspense fallback={<ShouldMountOnce />}>
979
- <AsyncText ms={1000} text="Child 1" />
980
- <AsyncText ms={2000} text="Child 2" />
981
- <AsyncText ms={3000} text="Child 3" />
979
+ <AsyncText text="Child 1" />
980
+ <AsyncText text="Child 2" />
981
+ <AsyncText text="Child 3" />
982
</Suspense>
983
);
984
}
@@ -1019,7 +1019,7 @@ describe('ReactSuspense', () => {
1019
1020
return (
1021
<Suspense fallback={<Text text="Loading..." />}>
1022
- <AsyncText key={tab} text={'Tab: ' + tab} ms={1000} />
1022
+ <AsyncText key={tab} text={'Tab: ' + tab} />
1023
<Text key={tab + 'sibling'} text=" + sibling" />
1024
</Suspense>
1025
);
@@ -1087,9 +1087,9 @@ describe('ReactSuspense', () => {
1087
function App() {
1088
return (
1089
<Suspense fallback={<Text text="Loading..." />}>
1090
- <AsyncText text="A" ms={1000} />
1091
- <AsyncText text="B" ms={2000} />
1092
- <AsyncText text="C" ms={3000} />
1090
+ <AsyncText text="A" />
1091
+ <AsyncText text="B" />
1092
+ <AsyncText text="C" />
1093
</Suspense>
1094
);
1095
}
packages/react-reconciler/src/__tests__/ReactSuspenseEffectsSemantics-test.js
+34
-42
@@ -258,7 +258,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
258
await act(() => {
259
ReactNoop.render(
260
<App>
261
- <AsyncText text="Async" ms={1000} />
261
+ <AsyncText text="Async" />
262
</App>,
263
);
264
});
@@ -376,7 +376,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
376
await act(() => {
377
ReactNoop.renderLegacySyncRoot(
378
<App>
379
- <AsyncText text="Async" ms={1000} />
379
+ <AsyncText text="Async" />
380
</App>,
381
);
382
});
@@ -503,7 +503,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
503
await act(() => {
504
ReactNoop.renderLegacySyncRoot(
505
<App>
506
- <AsyncText text="Async" ms={1000} />
506
+ <AsyncText text="Async" />
507
</App>,
508
);
509
});
@@ -633,7 +633,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
633
await act(async () => {
634
ReactNoop.render(
635
<App>
636
- <AsyncText text="Async" ms={1000} />
636
+ <AsyncText text="Async" />
637
</App>,
638
);
639
await waitFor([
@@ -773,7 +773,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
773
await act(async () => {
774
ReactNoop.render(
775
<App>
776
- <AsyncText text="Async" ms={1000} />
776
+ <AsyncText text="Async" />
777
</App>,
778
);
779
@@ -885,7 +885,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
885
await act(async () => {
886
ReactNoop.render(
887
<App>
888
- <AsyncText text="Async" ms={1000} />
888
+ <AsyncText text="Async" />
889
</App>,
890
);
891
await waitFor([
@@ -999,7 +999,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
999
await act(async () => {
1000
ReactNoop.render(
1001
<App>
1002
- <AsyncText text="Async" ms={1000} />
1002
+ <AsyncText text="Async" />
1003
</App>,
1004
);
1005
await waitFor([
@@ -1097,7 +1097,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
1097
// Suspend the inner Suspense subtree (only inner effects should be destroyed)
1098
await act(() => {
1099
ReactNoop.render(
1100
- <App innerChildren={<AsyncText text="InnerAsync_1" ms={1000} />} />,
1100
+ <App innerChildren={<AsyncText text="InnerAsync_1" />} />,
1101
);
1102
});
1103
assertLog([
@@ -1122,8 +1122,8 @@ describe('ReactSuspenseEffectsSemantics', () => {
1122
await act(() => {
1123
ReactNoop.render(
1124
<App
1125
- outerChildren={<AsyncText text="OuterAsync_1" ms={1000} />}
1126
- innerChildren={<AsyncText text="InnerAsync_1" ms={1000} />}
1125
+ outerChildren={<AsyncText text="OuterAsync_1" />}
1126
+ innerChildren={<AsyncText text="InnerAsync_1" />}
1127
/>,
1128
);
1129
});
@@ -1164,8 +1164,8 @@ describe('ReactSuspenseEffectsSemantics', () => {
1164
await act(() => {
1165
ReactNoop.render(
1166
<App
1167
- outerChildren={<AsyncText text="OuterAsync_1" ms={1000} />}
1168
- innerChildren={<AsyncText text="InnerAsync_2" ms={1000} />}
1167
+ outerChildren={<AsyncText text="OuterAsync_1" />}
1168
+ innerChildren={<AsyncText text="InnerAsync_2" />}
1169
/>,
1170
);
1171
});
@@ -1236,8 +1236,8 @@ describe('ReactSuspenseEffectsSemantics', () => {
1236
await act(() => {
1237
ReactNoop.render(
1238
<App
1239
- outerChildren={<AsyncText text="OuterAsync_2" ms={1000} />}
1240
- innerChildren={<AsyncText text="InnerAsync_2" ms={1000} />}
1239
+ outerChildren={<AsyncText text="OuterAsync_2" />}
1240
+ innerChildren={<AsyncText text="InnerAsync_2" />}
1241
/>,
1242
);
1243
});
@@ -1325,7 +1325,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
1325
// Suspend the inner Suspense subtree (only inner effects should be destroyed)
1326
await act(() => {
1327
ReactNoop.render(
1328
- <App innerChildren={<AsyncText text="InnerAsync_1" ms={1000} />} />,
1328
+ <App innerChildren={<AsyncText text="InnerAsync_1" />} />,
1329
);
1330
});
1331
assertLog([
@@ -1350,8 +1350,8 @@ describe('ReactSuspenseEffectsSemantics', () => {
1350
await act(() => {
1351
ReactNoop.render(
1352
<App
1353
- outerChildren={<AsyncText text="OuterAsync_1" ms={1000} />}
1354
- innerChildren={<AsyncText text="InnerAsync_1" ms={1000} />}
1353
+ outerChildren={<AsyncText text="OuterAsync_1" />}
1354
+ innerChildren={<AsyncText text="InnerAsync_1" />}
1355
/>,
1356
);
1357
});
@@ -1448,7 +1448,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
1448
// Suspend the outer shell
1449
await act(async () => {
1450
ReactNoop.render(
1451
- <App outerChildren={<AsyncText text="OutsideAsync" ms={1000} />} />,
1451
+ <App outerChildren={<AsyncText text="OutsideAsync" />} />,
1452
);
1453
await waitFor([
1454
'Text:Inside render',
@@ -1478,8 +1478,8 @@ describe('ReactSuspenseEffectsSemantics', () => {
1478
await act(async () => {
1479
ReactNoop.render(
1480
<App
1481
- fallbackChildren={<AsyncText text="FallbackAsync" ms={1000} />}
1482
- outerChildren={<AsyncText text="OutsideAsync" ms={1000} />}
1481
+ fallbackChildren={<AsyncText text="FallbackAsync" />}
1482
+ outerChildren={<AsyncText text="OutsideAsync" />}
1483
/>,
1484
);
1485
await waitFor([
@@ -1577,8 +1577,8 @@ describe('ReactSuspenseEffectsSemantics', () => {
1577
await act(() => {
1578
ReactNoop.render(
1579
<App
1580
- outerChildren={<AsyncText text="OutsideAsync" ms={1000} />}
1581
- fallbackChildren={<AsyncText text="FallbackAsync" ms={1000} />}
1580
+ outerChildren={<AsyncText text="OutsideAsync" />}
1581
+ fallbackChildren={<AsyncText text="FallbackAsync" />}
1582
/>,
1583
);
1584
});
@@ -1807,7 +1807,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
1807
ReactNoop.render(
1808
<ErrorBoundary fallback={<Text text="Error" />}>
1809
<App>
1810
- <AsyncText text="Async" ms={1000} />
1810
+ <AsyncText text="Async" />
1811
</App>
1812
</ErrorBoundary>,
1813
);
@@ -1941,7 +1941,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
1941
ReactNoop.render(
1942
<ErrorBoundary fallback={<Text text="Error" />}>
1943
<App>
1944
- <AsyncText text="Async" ms={1000} />
1944
+ <AsyncText text="Async" />
1945
</App>
1946
</ErrorBoundary>,
1947
);
@@ -2050,7 +2050,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
2050
ReactNoop.render(
2051
<ErrorBoundary fallback={<Text text="Error" />}>
2052
<App>
2053
- <AsyncText text="Async" ms={1000} />
2053
+ <AsyncText text="Async" />
2054
</App>
2055
</ErrorBoundary>,
2056
);
@@ -2184,7 +2184,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
2184
ReactNoop.render(
2185
<ErrorBoundary fallback={<Text text="Error" />}>
2186
<App>
2187
- <AsyncText text="Async" ms={1000} />
2187
+ <AsyncText text="Async" />
2188
</App>
2189
</ErrorBoundary>,
2190
);
@@ -2276,8 +2276,8 @@ describe('ReactSuspenseEffectsSemantics', () => {
2276
await act(async () => {
2277
ReactNoop.render(
2278
<App>
2279
- <AsyncText text="Async_1" ms={1000} />
2280
- <AsyncText text="Async_2" ms={2000} />
2279
+ <AsyncText text="Async_1" />
2280
+ <AsyncText text="Async_2" />
2281
</App>,
2282
);
2283
await waitFor([
@@ -2581,7 +2581,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
2581
// Suspend the inner Suspense subtree (only inner effects should be destroyed)
2582
await act(() => {
2583
ReactNoop.renderLegacySyncRoot(
2584
- <App children={<AsyncText text="Async" ms={1000} />} />,
2584
+ <App children={<AsyncText text="Async" />} />,
2585
);
2586
});
2587
await advanceTimers(1000);
@@ -2661,9 +2661,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
2661
2662
// Suspend the inner Suspense subtree (only inner effects should be destroyed)
2663
await act(() => {
2664
- ReactNoop.render(
2665
- <App children={<AsyncText text="Async" ms={1000} />} />,
2666
- );
2664
+ ReactNoop.render(<App children={<AsyncText text="Async" />} />);
2665
});
2666
await advanceTimers(1000);
2667
assertLog([
@@ -2764,9 +2762,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
2762
2763
// Suspend the inner Suspense subtree (only inner effects should be destroyed)
2764
await act(() => {
2767
- ReactNoop.render(
2768
- <App children={<AsyncText text="Async" ms={1000} />} />,
2769
- );
2765
+ ReactNoop.render(<App children={<AsyncText text="Async" />} />);
2766
});
2767
await advanceTimers(1000);
2768
assertLog([
@@ -2863,9 +2859,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
2859
2860
// Suspend the inner Suspense subtree (only inner effects should be destroyed)
2861
await act(() => {
2866
- ReactNoop.render(
2867
- <App children={<AsyncText text="Async" ms={1000} />} />,
2868
- );
2862
+ ReactNoop.render(<App children={<AsyncText text="Async" />} />);
2863
});
2864
await advanceTimers(1000);
2865
assertLog([
@@ -2967,9 +2961,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
2961
2962
// Suspend the inner Suspense subtree (only inner effects should be destroyed)
2963
await act(() => {
2970
- ReactNoop.render(
2971
- <App children={<AsyncText text="Async" ms={1000} />} />,
2972
- );
2964
+ ReactNoop.render(<App children={<AsyncText text="Async" />} />);
2965
});
2966
await advanceTimers(1000);
2967
assertLog([
@@ -3078,7 +3070,7 @@ describe('ReactSuspenseEffectsSemantics', () => {
3070
ReactNoop.render(
3071
<ErrorBoundary fallback={<Text text="Error" />}>
3072
<App>
3081
- <AsyncText text="Async" ms={1000} />
3073
+ <AsyncText text="Async" />
3074
</App>
3075
</ErrorBoundary>,
3076
);
packages/react-reconciler/src/__tests__/ReactSuspenseFallback-test.js
+6
-6
@@ -135,7 +135,7 @@ describe('ReactSuspenseFallback', () => {
135
it('suspends and shows fallback', async () => {
136
ReactNoop.render(
137
<Suspense fallback={<Text text="Loading..." />}>
138
- <AsyncText text="A" ms={100} />
138
+ <AsyncText text="A" />
139
</Suspense>,
140
);
141
@@ -147,7 +147,7 @@ describe('ReactSuspenseFallback', () => {
147
it('suspends and shows null fallback', async () => {
148
ReactNoop.render(
149
<Suspense fallback={null}>
150
- <AsyncText text="A" ms={100} />
150
+ <AsyncText text="A" />
151
</Suspense>,
152
);
153
@@ -162,7 +162,7 @@ describe('ReactSuspenseFallback', () => {
162
it('suspends and shows undefined fallback', async () => {
163
ReactNoop.render(
164
<Suspense>
165
- <AsyncText text="A" ms={100} />
165
+ <AsyncText text="A" />
166
</Suspense>,
167
);
168
@@ -178,7 +178,7 @@ describe('ReactSuspenseFallback', () => {
178
ReactNoop.render(
179
<Suspense fallback={<Text text="Should not show..." />}>
180
<Suspense fallback={<Text text="Loading..." />}>
181
- <AsyncText text="A" ms={100} />
181
+ <AsyncText text="A" />
182
</Suspense>
183
</Suspense>,
184
);
@@ -192,7 +192,7 @@ describe('ReactSuspenseFallback', () => {
192
ReactNoop.render(
193
<Suspense fallback={<Text text="Should not show..." />}>
194
<Suspense>
195
- <AsyncText text="A" ms={100} />
195
+ <AsyncText text="A" />
196
</Suspense>
197
</Suspense>,
198
);
@@ -209,7 +209,7 @@ describe('ReactSuspenseFallback', () => {
209
ReactNoop.render(
210
<Suspense fallback={<Text text="Should not show..." />}>
211
<Suspense fallback={null}>
212
- <AsyncText text="A" ms={100} />
212
+ <AsyncText text="A" />
213
</Suspense>
214
</Suspense>,
215
);
packages/react-reconciler/src/__tests__/ReactSuspenseWithNoopRenderer-test.js
+6
-6
@@ -208,7 +208,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {
208
<>
209
<Suspense fallback={<Text text="Loading..." />}>
210
<Bar>
211
- <AsyncText text="A" ms={100} />
211
+ <AsyncText text="A" />
212
<Text text="B" />
213
</Bar>
214
</Suspense>
@@ -422,7 +422,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {
422
<Suspense fallback={<Text text="Loading..." />}>
423
{renderContent ? (
424
<ErrorBoundary ref={errorBoundary}>
425
- <AsyncText text="Result" ms={1000} />
425
+ <AsyncText text="Result" />
426
</ErrorBoundary>
427
) : null}
428
</Suspense>
@@ -619,7 +619,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {
619
}
620
return (
621
<Suspense fallback="Loading...">
622
- <AsyncText ms={2000} text="Async" />
622
+ <AsyncText text="Async" />
623
</Suspense>
624
);
625
}
@@ -715,9 +715,9 @@ describe('ReactSuspenseWithNoopRenderer', () => {
715
<Fragment>
716
<Text text="Sync" />
717
<Suspense fallback={<Text text="Loading outer..." />}>
718
- <AsyncText text="Outer content" ms={300} />
718
+ <AsyncText text="Outer content" />
719
<Suspense fallback={<Text text="Loading inner..." />}>
720
- <AsyncText text="Inner content" ms={1000} />
720
+ <AsyncText text="Inner content" />
721
</Suspense>
722
</Suspense>
723
</Fragment>,
@@ -2821,7 +2821,7 @@ describe('ReactSuspenseWithNoopRenderer', () => {
2821
<Offscreen />
2822
</LegacyHiddenDiv>
2823
<Suspense fallback={<Text text="Loading..." />}>
2824
- {showContent ? <AsyncText text="A" ms={2000} /> : null}
2824
+ {showContent ? <AsyncText text="A" /> : null}
2825
</Suspense>
2826
</>
2827
);
packages/react-reconciler/src/__tests__/ReactTransition-test.js
+1
-1
@@ -719,7 +719,7 @@ describe('ReactTransition', () => {
719
<>
720
<Text text={`A${step}`} />
721
<Suspense fallback={<Text text="Loading..." />}>
722
- {shouldSuspend ? <AsyncText text="Async" ms={2000} /> : null}
722
+ {shouldSuspend ? <AsyncText text="Async" /> : null}
723
</Suspense>
724
<Text text={`B${step}`} />
725
<Text text={`C${step}`} />