@samitouri / QOS-React-2 / commits / 577f2de46c

enableCacheElement flag (#24131)

* enableCacheElement flag * Update packages/shared/forks/ReactFeatureFlags.testing.js Co-authored-by: Ricky <rickhanlonii@gmail.com> * Update packages/shared/forks/ReactFeatureFlags.test-renderer.js Co-authored-by: Ricky <rickhanlonii@gmail.com> * Update packages/shared/forks/ReactFeatureFlags.native-oss.js Co-authored-by: Ricky <rickhanlonii@gmail.com> * Update packages/shared/ReactFeatureFlags.js Co-authored-by: Ricky <rickhanlonii@gmail.com> Co-authored-by: Dave McCabe <davemccabe@fb.com> Co-authored-by: Ricky <rickhanlonii@gmail.com>

David McCabe committed Mar 20, 2022 at 20:41 UTC 577f2de46cb2f6d71380551478a02de3965a764b
10 files changed +11 -2
packages/shared/ReactFeatureFlags.js
+1
@@ -96,6 +96,7 @@ export const enableLegacyFBSupport = false;
96 // -----------------------------------------------------------------------------
97
98 export const enableCache = __EXPERIMENTAL__;
99 +export const enableCacheElement = __EXPERIMENTAL__;
100
101 export const enableTransitionTracing = false;
102
packages/shared/forks/ReactFeatureFlags.native-fb.js
+1
@@ -30,6 +30,7 @@ export const enableSuspenseServerRenderer = false;
30 export const enableSelectiveHydration = false;
31 export const enableLazyElements = false;
32 export const enableCache = false;
33 +export const enableCacheElement = true;
34 export const enableSchedulerDebugging = false;
35 export const debugRenderPhaseSideEffectsForStrictMode = true;
36 export const disableJavaScriptURLs = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
+1
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
24 export const enableSelectiveHydration = false;
25 export const enableLazyElements = false;
26 export const enableCache = false;
27 +export const enableCacheElement = false;
28 export const disableJavaScriptURLs = false;
29 export const disableCommentsAsDOMContainers = true;
30 export const disableInputAttributeSyncing = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+1
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
24 export const enableSelectiveHydration = false;
25 export const enableLazyElements = false;
26 export const enableCache = __EXPERIMENTAL__;
27 +export const enableCacheElement = __EXPERIMENTAL__;
28 export const disableJavaScriptURLs = false;
29 export const disableCommentsAsDOMContainers = true;
30 export const disableInputAttributeSyncing = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
+1
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
24 export const enableSelectiveHydration = false;
25 export const enableLazyElements = false;
26 export const enableCache = true;
27 +export const enableCacheElement = true;
28 export const disableJavaScriptURLs = false;
29 export const disableCommentsAsDOMContainers = true;
30 export const disableInputAttributeSyncing = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+1
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
24 export const enableSelectiveHydration = false;
25 export const enableLazyElements = false;
26 export const enableCache = true;
27 +export const enableCacheElement = true;
28 export const enableSchedulerDebugging = false;
29 export const disableJavaScriptURLs = false;
30 export const disableCommentsAsDOMContainers = true;
packages/shared/forks/ReactFeatureFlags.testing.js
+1
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = false;
24 export const enableSelectiveHydration = false;
25 export const enableLazyElements = false;
26 export const enableCache = __EXPERIMENTAL__;
27 +export const enableCacheElement = __EXPERIMENTAL__;
28 export const disableJavaScriptURLs = false;
29 export const disableCommentsAsDOMContainers = true;
30 export const disableInputAttributeSyncing = false;
packages/shared/forks/ReactFeatureFlags.testing.www.js
+1
@@ -24,6 +24,7 @@ export const enableSuspenseServerRenderer = true;
24 export const enableSelectiveHydration = true;
25 export const enableLazyElements = false;
26 export const enableCache = true;
27 +export const enableCacheElement = true;
28 export const disableJavaScriptURLs = true;
29 export const disableCommentsAsDOMContainers = true;
30 export const disableInputAttributeSyncing = false;
packages/shared/forks/ReactFeatureFlags.www.js
+1
@@ -72,6 +72,7 @@ export const enableSelectiveHydration = true;
72
73 export const enableLazyElements = true;
74 export const enableCache = true;
75 +export const enableCacheElement = true;
76
77 export const disableJavaScriptURLs = true;
78
packages/shared/isValidElementType.js
+2 -2
@@ -27,7 +27,7 @@ import {
27 } from 'shared/ReactSymbols';
28 import {
29 enableScopeAPI,
30 - enableCache,
30 + enableCacheElement,
31 enableTransitionTracing,
32 enableDebugTracing,
33 enableLegacyHidden,
@@ -51,7 +51,7 @@ export default function isValidElementType(type: mixed) {
51 (enableLegacyHidden && type === REACT_LEGACY_HIDDEN_TYPE) ||
52 type === REACT_OFFSCREEN_TYPE ||
53 (enableScopeAPI && type === REACT_SCOPE_TYPE) ||
54 - (enableCache && type === REACT_CACHE_TYPE) ||
54 + (enableCacheElement && type === REACT_CACHE_TYPE) ||
55 (enableTransitionTracing && type === REACT_TRACING_MARKER_TYPE)
56 ) {
57 return true;