Inline expectations in tests as they are used once
Dan Abramov committed
May 26, 2016 at 01:29 UTC
58c9fda94655327a35e239a2770031f93b8e9948
2 files changed
+8
-16
src/isomorphic/classic/element/__tests__/ReactElement-test.js
+6
-12
@@ -52,10 +52,9 @@ describe('ReactElement', function() {
52
expect(element.type).toBe(ComponentClass);
53
expect(element.key).toBe(null);
54
expect(element.ref).toBe(null);
55
- var expectation = {};
55
expect(Object.isFrozen(element)).toBe(true);
56
expect(Object.isFrozen(element.props)).toBe(true);
58
- expect(element.props).toEqual(expectation);
57
+ expect(element.props).toEqual({});
58
});
59
60
it('should warn when `key` is being accessed on createClass element', function() {
@@ -165,10 +164,9 @@ describe('ReactElement', function() {
164
expect(element.type).toBe('div');
165
expect(element.key).toBe(null);
166
expect(element.ref).toBe(null);
168
- var expectation = {};
167
expect(Object.isFrozen(element)).toBe(true);
168
expect(Object.isFrozen(element.props)).toBe(true);
171
- expect(element.props).toEqual(expectation);
169
+ expect(element.props).toEqual({});
170
});
171
172
it('returns an immutable element', function() {
@@ -211,10 +209,9 @@ describe('ReactElement', function() {
209
expect(element.type).toBe(ComponentClass);
210
expect(element.key).toBe('12');
211
expect(element.ref).toBe('34');
214
- var expectation = {foo: '56'};
212
expect(Object.isFrozen(element)).toBe(true);
213
expect(Object.isFrozen(element.props)).toBe(true);
217
- expect(element.props).toEqual(expectation);
214
+ expect(element.props).toEqual({foo: '56'});
215
});
216
217
it('extracts null key and ref', function() {
@@ -226,10 +223,9 @@ describe('ReactElement', function() {
223
expect(element.type).toBe(ComponentClass);
224
expect(element.key).toBe('null');
225
expect(element.ref).toBe(null);
229
- var expectation = {foo: '12'};
226
expect(Object.isFrozen(element)).toBe(true);
227
expect(Object.isFrozen(element.props)).toBe(true);
232
- expect(element.props).toEqual(expectation);
228
+ expect(element.props).toEqual({foo: '12'});
229
});
230
231
it('ignores undefined key and ref', function() {
@@ -242,10 +238,9 @@ describe('ReactElement', function() {
238
expect(element.type).toBe(ComponentClass);
239
expect(element.key).toBe(null);
240
expect(element.ref).toBe(null);
245
- var expectation = {foo: '56'};
241
expect(Object.isFrozen(element)).toBe(true);
242
expect(Object.isFrozen(element.props)).toBe(true);
248
- expect(element.props).toEqual(expectation);
243
+ expect(element.props).toEqual({foo: '56'});
244
});
245
246
it('ignores key and ref warning getters', function() {
@@ -263,10 +258,9 @@ describe('ReactElement', function() {
258
expect(element.type).toBe(ComponentClass);
259
expect(element.key).toBe('12');
260
expect(element.ref).toBe(null);
266
- var expectation = {foo: '56'};
261
expect(Object.isFrozen(element)).toBe(true);
262
expect(Object.isFrozen(element.props)).toBe(true);
269
- expect(element.props).toEqual(expectation);
263
+ expect(element.props).toEqual({foo: '56'});
264
});
265
266
it('preserves the owner on the element', function() {
src/isomorphic/classic/element/__tests__/ReactElementClone-test.js
+2
-4
@@ -344,10 +344,9 @@ describe('ReactElementClone', function() {
344
expect(clone.type).toBe(ComponentClass);
345
expect(clone.key).toBe('12');
346
expect(clone.ref).toBe('34');
347
- var expectation = {foo: 'ef'};
347
expect(Object.isFrozen(element)).toBe(true);
348
expect(Object.isFrozen(element.props)).toBe(true);
350
- expect(clone.props).toEqual(expectation);
349
+ expect(clone.props).toEqual({foo: 'ef'});
350
});
351
352
it('should extract null key and ref', function() {
@@ -365,10 +364,9 @@ describe('ReactElementClone', function() {
364
expect(clone.type).toBe(ComponentClass);
365
expect(clone.key).toBe('null');
366
expect(clone.ref).toBe(null);
368
- var expectation = {foo: 'ef'};
367
expect(Object.isFrozen(element)).toBe(true);
368
expect(Object.isFrozen(element.props)).toBe(true);
371
- expect(clone.props).toEqual(expectation);
369
+ expect(clone.props).toEqual({foo: 'ef'});
370
});
371
372
});