[cleanup] remove unused values from ReactFeatureFlags.www-dynamic (#25575)
These values are never imported into `ReactFeatureFlags.www.js`, so they're unused: - `allowConcurrentByDefault` - `consoleManagedByDevToolsDuringStrictMode` These values are never set in the WWW module (https://fburl.com/code/dsb2ohv8), so they're always `undefined` on www: - `createRootStrictEffectsByDefault` - `enableClientRenderFallbackOnTextMismatch`
Jan Kassens committed
Jan 10, 2023 at 23:26 UTC
7002a6743ebb24ed55af8f626c89dd39460230fc
2 files changed
+2
-6
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-4
@@ -25,9 +25,7 @@ export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
25
export const enableLazyContextPropagation = __VARIANT__;
26
export const enableSyncDefaultUpdates = __VARIANT__;
27
export const enableUnifiedSyncLane = __VARIANT__;
28
-export const consoleManagedByDevToolsDuringStrictMode = __VARIANT__;
28
export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = __VARIANT__;
30
-export const enableClientRenderFallbackOnTextMismatch = __VARIANT__;
29
export const enableTransitionTracing = __VARIANT__;
30
// Enable this flag to help with concurrent mode debugging.
31
// It logs information to the console about React scheduling, rendering, and commit phases.
@@ -57,7 +55,5 @@ export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
55
export const enableTrustedTypesIntegration = false;
56
export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
57
export const disableNativeComponentFrames = false;
60
-export const createRootStrictEffectsByDefault = false;
61
-export const allowConcurrentByDefault = true;
58
// You probably *don't* want to add more hardcoded ones.
59
// Instead, try to add them above with the __VARIANT__ value.
packages/shared/forks/ReactFeatureFlags.www.js
+2
-2
@@ -25,7 +25,6 @@ export const {
25
deferRenderPhaseUpdateToNextBatch,
26
enableDebugTracing,
27
skipUnmountedBoundaries,
28
- createRootStrictEffectsByDefault,
28
enableUseRefAccessWarning,
29
disableNativeComponentFrames,
30
disableSchedulerTimeoutInWorkLoop,
@@ -33,7 +32,6 @@ export const {
32
enableSyncDefaultUpdates,
33
enableUnifiedSyncLane,
34
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
36
- enableClientRenderFallbackOnTextMismatch,
35
enableTransitionTracing,
36
} = dynamicFeatureFlags;
37
@@ -48,6 +46,7 @@ export const enableProfilerNestedUpdateScheduledHook: boolean =
46
__PROFILE__ && dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;
47
export const enableUpdaterTracking = __PROFILE__;
48
49
+export const createRootStrictEffectsByDefault = false;
50
export const enableSuspenseAvoidThisFallback = true;
51
export const enableSuspenseAvoidThisFallbackFizz = false;
52
export const enableCPUSuspense = true;
@@ -56,6 +55,7 @@ export const enableUseHook = true;
55
export const enableUseMemoCacheHook = true;
56
export const enableUseEffectEventHook = true;
57
export const enableHostSingletons = true;
58
+export const enableClientRenderFallbackOnTextMismatch = false;
59
60
// Logs additional User Timing API marks for use with an experimental profiling tool.
61
export const enableSchedulingProfiler: boolean =