The library for web and native user interfaces.
internalPropNames isn't necessary, so remove it
Perhaps we'll bring it back as a future perf optimization if that appears useful.
Ben Alpert committed
Jun 11, 2013 at 19:02 UTC
731aa8ead11d2e8d787585a7d3aaaffa830d0a81
2 files changed
-16
src/core/ReactComponent.js
-12
@@ -35,13 +35,6 @@ var merge = require('merge');
35
*/
36
var OWNER = '{owner}';
37
38
-/**
39
- * Internal properties that shouldn't be considered when modifying node
40
- * attributes.
41
- */
42
-var internalPropNames = {children: true};
43
-internalPropNames[OWNER] = true;
44
-
38
/**
39
* Every React component is in one of these life cycles.
40
*/
@@ -138,11 +131,6 @@ function appendNestedChildren(parentKey, sourceArray, targetArray) {
131
*/
132
var ReactComponent = {
133
141
- /**
142
- * @internal
143
- */
144
- internalPropNames: internalPropNames,
145
-
134
/**
135
* @param {?object} object
136
* @return {boolean} True if `object` is a valid component.
src/core/ReactNativeComponent.js
-4
@@ -32,8 +32,6 @@ var keyOf = require('keyOf');
32
var merge = require('merge');
33
var mixInto = require('mixInto');
34
35
-var internalPropNames = ReactComponent.internalPropNames;
36
-
35
var putListener = ReactEventEmitter.putListener;
36
var deleteListener = ReactEventEmitter.deleteListener;
37
var registrationNames = ReactEventEmitter.registrationNames;
@@ -236,7 +234,6 @@ ReactNativeComponent.Mixin = {
234
this._rootNodeID,
235
''
236
);
239
- } else if (internalPropNames[propKey]) {
237
} else if (registrationNames[propKey]) {
238
deleteListener(this._rootNodeID, propKey);
239
} else {
@@ -291,7 +288,6 @@ ReactNativeComponent.Mixin = {
288
this._rootNodeID,
289
'' + nextProp
290
);
294
- } else if (internalPropNames[propKey]) {
291
} else if (registrationNames[propKey]) {
292
putListener(this._rootNodeID, propKey, nextProp);
293
} else {