@samitouri / QOS-React-2 / commits / 7bcc687720

Remove argument committedLanes from reappearLayoutEffects and recursivelyTraverseReappearLayoutEffects (#25080)

Samuel Susla committed Aug 11, 2022 at 15:24 UTC 7bcc687720bbb31873768399dd87c27d8c231011
2 files changed -22
packages/react-reconciler/src/ReactFiberCommitWork.new.js
-11
@@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
1099 recursivelyTraverseReappearLayoutEffects(
1100 finishedRoot,
1101 finishedWork,
1102 - committedLanes,
1102 includeWorkInProgressEffects,
1103 );
1104 } else {
@@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
2703 finishedRoot: FiberRoot,
2704 current: Fiber | null,
2705 finishedWork: Fiber,
2707 - committedLanes: Lanes,
2706 // This function visits both newly finished work and nodes that were re-used
2707 // from a previously committed tree. We cannot check non-static flags if the
2708 // node was reused.
@@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
2717 recursivelyTraverseReappearLayoutEffects(
2718 finishedRoot,
2719 finishedWork,
2722 - committedLanes,
2720 includeWorkInProgressEffects,
2721 );
2722 // TODO: Check flags & LayoutStatic
@@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
2727 recursivelyTraverseReappearLayoutEffects(
2728 finishedRoot,
2729 finishedWork,
2733 - committedLanes,
2730 includeWorkInProgressEffects,
2731 );
2732
@@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
2768 recursivelyTraverseReappearLayoutEffects(
2769 finishedRoot,
2770 finishedWork,
2775 - committedLanes,
2771 includeWorkInProgressEffects,
2772 );
2773
@@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
2787 recursivelyTraverseReappearLayoutEffects(
2788 finishedRoot,
2789 finishedWork,
2795 - committedLanes,
2790 includeWorkInProgressEffects,
2791 );
2792 // TODO: Figure out how Profiler updates should work with Offscreen
@@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
2799 recursivelyTraverseReappearLayoutEffects(
2800 finishedRoot,
2801 finishedWork,
2808 - committedLanes,
2802 includeWorkInProgressEffects,
2803 );
2804
@@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
2818 recursivelyTraverseReappearLayoutEffects(
2819 finishedRoot,
2820 finishedWork,
2828 - committedLanes,
2821 includeWorkInProgressEffects,
2822 );
2823 }
@@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
2827 recursivelyTraverseReappearLayoutEffects(
2828 finishedRoot,
2829 finishedWork,
2838 - committedLanes,
2830 includeWorkInProgressEffects,
2831 );
2832 break;
@@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
2837 function recursivelyTraverseReappearLayoutEffects(
2838 finishedRoot: FiberRoot,
2839 parentFiber: Fiber,
2849 - committedLanes: Lanes,
2840 includeWorkInProgressEffects: boolean,
2841 ) {
2842 // This function visits both newly finished work and nodes that were re-used
@@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
2855 finishedRoot,
2856 current,
2857 child,
2868 - committedLanes,
2858 childShouldIncludeWorkInProgressEffects,
2859 );
2860 child = child.sibling;
packages/react-reconciler/src/ReactFiberCommitWork.old.js
-11
@@ -1099,7 +1099,6 @@ function commitLayoutEffectOnFiber(
1099 recursivelyTraverseReappearLayoutEffects(
1100 finishedRoot,
1101 finishedWork,
1102 - committedLanes,
1102 includeWorkInProgressEffects,
1103 );
1104 } else {
@@ -2704,7 +2703,6 @@ function reappearLayoutEffects(
2703 finishedRoot: FiberRoot,
2704 current: Fiber | null,
2705 finishedWork: Fiber,
2707 - committedLanes: Lanes,
2706 // This function visits both newly finished work and nodes that were re-used
2707 // from a previously committed tree. We cannot check non-static flags if the
2708 // node was reused.
@@ -2719,7 +2717,6 @@ function reappearLayoutEffects(
2717 recursivelyTraverseReappearLayoutEffects(
2718 finishedRoot,
2719 finishedWork,
2722 - committedLanes,
2720 includeWorkInProgressEffects,
2721 );
2722 // TODO: Check flags & LayoutStatic
@@ -2730,7 +2727,6 @@ function reappearLayoutEffects(
2727 recursivelyTraverseReappearLayoutEffects(
2728 finishedRoot,
2729 finishedWork,
2733 - committedLanes,
2730 includeWorkInProgressEffects,
2731 );
2732
@@ -2772,7 +2768,6 @@ function reappearLayoutEffects(
2768 recursivelyTraverseReappearLayoutEffects(
2769 finishedRoot,
2770 finishedWork,
2775 - committedLanes,
2771 includeWorkInProgressEffects,
2772 );
2773
@@ -2792,7 +2787,6 @@ function reappearLayoutEffects(
2787 recursivelyTraverseReappearLayoutEffects(
2788 finishedRoot,
2789 finishedWork,
2795 - committedLanes,
2790 includeWorkInProgressEffects,
2791 );
2792 // TODO: Figure out how Profiler updates should work with Offscreen
@@ -2805,7 +2799,6 @@ function reappearLayoutEffects(
2799 recursivelyTraverseReappearLayoutEffects(
2800 finishedRoot,
2801 finishedWork,
2808 - committedLanes,
2802 includeWorkInProgressEffects,
2803 );
2804
@@ -2825,7 +2818,6 @@ function reappearLayoutEffects(
2818 recursivelyTraverseReappearLayoutEffects(
2819 finishedRoot,
2820 finishedWork,
2828 - committedLanes,
2821 includeWorkInProgressEffects,
2822 );
2823 }
@@ -2835,7 +2827,6 @@ function reappearLayoutEffects(
2827 recursivelyTraverseReappearLayoutEffects(
2828 finishedRoot,
2829 finishedWork,
2838 - committedLanes,
2830 includeWorkInProgressEffects,
2831 );
2832 break;
@@ -2846,7 +2837,6 @@ function reappearLayoutEffects(
2837 function recursivelyTraverseReappearLayoutEffects(
2838 finishedRoot: FiberRoot,
2839 parentFiber: Fiber,
2849 - committedLanes: Lanes,
2840 includeWorkInProgressEffects: boolean,
2841 ) {
2842 // This function visits both newly finished work and nodes that were re-used
@@ -2865,7 +2855,6 @@ function recursivelyTraverseReappearLayoutEffects(
2855 finishedRoot,
2856 current,
2857 child,
2868 - committedLanes,
2858 childShouldIncludeWorkInProgressEffects,
2859 );
2860 child = child.sibling;