Fix enableTransitionTracing flag (#24801)
Move `enableTransitionTracing` to `dynamicFeatureFlags` so it runs when you run `yarn test`
Luna Ruan committed
Jun 28, 2022 at 13:09 UTC
88574c1b8bd4ed187f09a9c91d327784fe50dbe8
5 files changed
+10
-2
packages/react-noop-renderer/src/createReactNoop.js
+2
@@ -806,6 +806,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
806
false,
807
'',
808
onRecoverableError,
809
+ null,
810
);
811
roots.set(rootID, root);
812
}
@@ -859,6 +860,7 @@ function createReactNoop(reconciler: Function, useMutation: boolean) {
860
false,
861
'',
862
onRecoverableError,
863
+ null,
864
);
865
return {
866
_Scheduler: Scheduler,
packages/react-reconciler/src/ReactFiber.new.js
+3
@@ -734,6 +734,9 @@ export function createFiberFromLegacyHidden(
734
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
735
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
736
fiber.lanes = lanes;
737
+ // Adding a stateNode for legacy hidden because it's currently using
738
+ // the offscreen implementation, which depends on a state node
739
+ fiber.stateNode = {};
740
return fiber;
741
}
742
packages/react-reconciler/src/ReactFiber.old.js
+3
@@ -734,6 +734,9 @@ export function createFiberFromLegacyHidden(
734
const fiber = createFiber(LegacyHiddenComponent, pendingProps, key, mode);
735
fiber.elementType = REACT_LEGACY_HIDDEN_TYPE;
736
fiber.lanes = lanes;
737
+ // Adding a stateNode for legacy hidden because it's currently using
738
+ // the offscreen implementation, which depends on a state node
739
+ fiber.stateNode = {};
740
return fiber;
741
}
742
packages/react/index.classic.fb.js
+1
@@ -34,6 +34,7 @@ export {
34
startTransition,
35
startTransition as unstable_startTransition, // TODO: Remove once call sights updated to startTransition
36
unstable_Cache,
37
+ unstable_TracingMarker,
38
unstable_DebugTracingMode,
39
unstable_LegacyHidden,
40
unstable_Offscreen,
packages/shared/forks/ReactFeatureFlags.www.js
+1
-2
@@ -33,6 +33,7 @@ export const {
33
enableSyncDefaultUpdates,
34
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
35
enableClientRenderFallbackOnTextMismatch,
36
+ enableTransitionTracing,
37
} = dynamicFeatureFlags;
38
39
// On WWW, __EXPERIMENTAL__ is used for a new modern build.
@@ -106,8 +107,6 @@ export const enableUseMutableSource = true;
107
108
export const enableCustomElementPropertySupport = __EXPERIMENTAL__;
109
109
-export const enableTransitionTracing = false;
110
-
110
export const enableSymbolFallbackForWWW = true;
111
// Flow magic to verify the exports of this file match the original version.
112
// eslint-disable-next-line no-unused-vars