@samitouri / QOS-React-2 / commits / 987292815c

Remove feature flag enableStrictEffects (#25387)

Samuel Susla committed Oct 19, 2022 at 10:57 UTC 987292815c68be0fd5916d1f9b0d6c983e2db7ce
24 files changed +31 -118
packages/react-reconciler/src/ReactFiber.new.js
+2 -9
@@ -30,7 +30,6 @@ import {
30 import {
31 createRootStrictEffectsByDefault,
32 enableCache,
33 - enableStrictEffects,
33 enableProfilerTimer,
34 enableScopeAPI,
35 enableLegacyHidden,
@@ -449,13 +448,7 @@ export function createHostRootFiber(
448 let mode;
449 if (tag === ConcurrentRoot) {
450 mode = ConcurrentMode;
452 - if (isStrictMode === true) {
453 - mode |= StrictLegacyMode;
454 -
455 - if (enableStrictEffects) {
456 - mode |= StrictEffectsMode;
457 - }
458 - } else if (enableStrictEffects && createRootStrictEffectsByDefault) {
451 + if (isStrictMode === true || createRootStrictEffectsByDefault) {
452 mode |= StrictLegacyMode | StrictEffectsMode;
453 }
454 if (
@@ -531,7 +524,7 @@ export function createFiberFromTypeAndProps(
524 case REACT_STRICT_MODE_TYPE:
525 fiberTag = Mode;
526 mode |= StrictLegacyMode;
534 - if (enableStrictEffects && (mode & ConcurrentMode) !== NoMode) {
527 + if ((mode & ConcurrentMode) !== NoMode) {
528 // Strict effects should never run on legacy roots
529 mode |= StrictEffectsMode;
530 }
packages/react-reconciler/src/ReactFiber.old.js
+2 -9
@@ -30,7 +30,6 @@ import {
30 import {
31 createRootStrictEffectsByDefault,
32 enableCache,
33 - enableStrictEffects,
33 enableProfilerTimer,
34 enableScopeAPI,
35 enableLegacyHidden,
@@ -449,13 +448,7 @@ export function createHostRootFiber(
448 let mode;
449 if (tag === ConcurrentRoot) {
450 mode = ConcurrentMode;
452 - if (isStrictMode === true) {
453 - mode |= StrictLegacyMode;
454 -
455 - if (enableStrictEffects) {
456 - mode |= StrictEffectsMode;
457 - }
458 - } else if (enableStrictEffects && createRootStrictEffectsByDefault) {
451 + if (isStrictMode === true || createRootStrictEffectsByDefault) {
452 mode |= StrictLegacyMode | StrictEffectsMode;
453 }
454 if (
@@ -531,7 +524,7 @@ export function createFiberFromTypeAndProps(
524 case REACT_STRICT_MODE_TYPE:
525 fiberTag = Mode;
526 mode |= StrictLegacyMode;
534 - if (enableStrictEffects && (mode & ConcurrentMode) !== NoMode) {
527 + if ((mode & ConcurrentMode) !== NoMode) {
528 // Strict effects should never run on legacy roots
529 mode |= StrictEffectsMode;
530 }
packages/react-reconciler/src/ReactFiberClassComponent.new.js
+4 -21
@@ -26,7 +26,6 @@ import {
26 enableSchedulingProfiler,
27 warnAboutDeprecatedLifecycles,
28 enableLazyContextPropagation,
29 - enableStrictEffects,
29 } from 'shared/ReactFeatureFlags';
30 import ReactStrictModeWarnings from './ReactStrictModeWarnings.new';
31 import {isMounted} from './ReactFiberTreeReflection';
@@ -908,11 +907,7 @@ function mountClassInstance(
907
908 if (typeof instance.componentDidMount === 'function') {
909 let fiberFlags: Flags = Update | LayoutStatic;
911 - if (
912 - __DEV__ &&
913 - enableStrictEffects &&
914 - (workInProgress.mode & StrictEffectsMode) !== NoMode
915 - ) {
910 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
911 fiberFlags |= MountLayoutDev;
912 }
913 workInProgress.flags |= fiberFlags;
@@ -986,11 +981,7 @@ function resumeMountClassInstance(
981 // effect even though we're bailing out, so that cWU/cDU are called.
982 if (typeof instance.componentDidMount === 'function') {
983 let fiberFlags: Flags = Update | LayoutStatic;
989 - if (
990 - __DEV__ &&
991 - enableStrictEffects &&
992 - (workInProgress.mode & StrictEffectsMode) !== NoMode
993 - ) {
984 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
985 fiberFlags |= MountLayoutDev;
986 }
987 workInProgress.flags |= fiberFlags;
@@ -1037,11 +1028,7 @@ function resumeMountClassInstance(
1028 }
1029 if (typeof instance.componentDidMount === 'function') {
1030 let fiberFlags: Flags = Update | LayoutStatic;
1040 - if (
1041 - __DEV__ &&
1042 - enableStrictEffects &&
1043 - (workInProgress.mode & StrictEffectsMode) !== NoMode
1044 - ) {
1031 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
1032 fiberFlags |= MountLayoutDev;
1033 }
1034 workInProgress.flags |= fiberFlags;
@@ -1051,11 +1038,7 @@ function resumeMountClassInstance(
1038 // effect even though we're bailing out, so that cWU/cDU are called.
1039 if (typeof instance.componentDidMount === 'function') {
1040 let fiberFlags: Flags = Update | LayoutStatic;
1054 - if (
1055 - __DEV__ &&
1056 - enableStrictEffects &&
1057 - (workInProgress.mode & StrictEffectsMode) !== NoMode
1058 - ) {
1041 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
1042 fiberFlags |= MountLayoutDev;
1043 }
1044 workInProgress.flags |= fiberFlags;
packages/react-reconciler/src/ReactFiberClassComponent.old.js
+4 -21
@@ -26,7 +26,6 @@ import {
26 enableSchedulingProfiler,
27 warnAboutDeprecatedLifecycles,
28 enableLazyContextPropagation,
29 - enableStrictEffects,
29 } from 'shared/ReactFeatureFlags';
30 import ReactStrictModeWarnings from './ReactStrictModeWarnings.old';
31 import {isMounted} from './ReactFiberTreeReflection';
@@ -908,11 +907,7 @@ function mountClassInstance(
907
908 if (typeof instance.componentDidMount === 'function') {
909 let fiberFlags: Flags = Update | LayoutStatic;
911 - if (
912 - __DEV__ &&
913 - enableStrictEffects &&
914 - (workInProgress.mode & StrictEffectsMode) !== NoMode
915 - ) {
910 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
911 fiberFlags |= MountLayoutDev;
912 }
913 workInProgress.flags |= fiberFlags;
@@ -986,11 +981,7 @@ function resumeMountClassInstance(
981 // effect even though we're bailing out, so that cWU/cDU are called.
982 if (typeof instance.componentDidMount === 'function') {
983 let fiberFlags: Flags = Update | LayoutStatic;
989 - if (
990 - __DEV__ &&
991 - enableStrictEffects &&
992 - (workInProgress.mode & StrictEffectsMode) !== NoMode
993 - ) {
984 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
985 fiberFlags |= MountLayoutDev;
986 }
987 workInProgress.flags |= fiberFlags;
@@ -1037,11 +1028,7 @@ function resumeMountClassInstance(
1028 }
1029 if (typeof instance.componentDidMount === 'function') {
1030 let fiberFlags: Flags = Update | LayoutStatic;
1040 - if (
1041 - __DEV__ &&
1042 - enableStrictEffects &&
1043 - (workInProgress.mode & StrictEffectsMode) !== NoMode
1044 - ) {
1031 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
1032 fiberFlags |= MountLayoutDev;
1033 }
1034 workInProgress.flags |= fiberFlags;
@@ -1051,11 +1038,7 @@ function resumeMountClassInstance(
1038 // effect even though we're bailing out, so that cWU/cDU are called.
1039 if (typeof instance.componentDidMount === 'function') {
1040 let fiberFlags: Flags = Update | LayoutStatic;
1054 - if (
1055 - __DEV__ &&
1056 - enableStrictEffects &&
1057 - (workInProgress.mode & StrictEffectsMode) !== NoMode
1058 - ) {
1041 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
1042 fiberFlags |= MountLayoutDev;
1043 }
1044 workInProgress.flags |= fiberFlags;
packages/react-reconciler/src/ReactFiberCommitWork.new.js
+4 -5
@@ -54,7 +54,6 @@ import {
54 enableCache,
55 enableTransitionTracing,
56 enableUseEventHook,
57 - enableStrictEffects,
57 enableFloat,
58 enableLegacyHidden,
59 enableHostSingletons,
@@ -4350,7 +4349,7 @@ function commitPassiveUnmountInsideDeletedTreeOnFiber(
4349 }
4350
4351 function invokeLayoutEffectMountInDEV(fiber: Fiber): void {
4353 - if (__DEV__ && enableStrictEffects) {
4352 + if (__DEV__) {
4353 // We don't need to re-check StrictEffectsMode here.
4354 // This function is only called if that check has already passed.
4355 switch (fiber.tag) {
@@ -4378,7 +4377,7 @@ function invokeLayoutEffectMountInDEV(fiber: Fiber): void {
4377 }
4378
4379 function invokePassiveEffectMountInDEV(fiber: Fiber): void {
4381 - if (__DEV__ && enableStrictEffects) {
4380 + if (__DEV__) {
4381 // We don't need to re-check StrictEffectsMode here.
4382 // This function is only called if that check has already passed.
4383 switch (fiber.tag) {
@@ -4397,7 +4396,7 @@ function invokePassiveEffectMountInDEV(fiber: Fiber): void {
4396 }
4397
4398 function invokeLayoutEffectUnmountInDEV(fiber: Fiber): void {
4400 - if (__DEV__ && enableStrictEffects) {
4399 + if (__DEV__) {
4400 // We don't need to re-check StrictEffectsMode here.
4401 // This function is only called if that check has already passed.
4402 switch (fiber.tag) {
@@ -4427,7 +4426,7 @@ function invokeLayoutEffectUnmountInDEV(fiber: Fiber): void {
4426 }
4427
4428 function invokePassiveEffectUnmountInDEV(fiber: Fiber): void {
4430 - if (__DEV__ && enableStrictEffects) {
4429 + if (__DEV__) {
4430 // We don't need to re-check StrictEffectsMode here.
4431 // This function is only called if that check has already passed.
4432 switch (fiber.tag) {
packages/react-reconciler/src/ReactFiberCommitWork.old.js
+4 -5
@@ -54,7 +54,6 @@ import {
54 enableCache,
55 enableTransitionTracing,
56 enableUseEventHook,
57 - enableStrictEffects,
57 enableFloat,
58 enableLegacyHidden,
59 enableHostSingletons,
@@ -4350,7 +4349,7 @@ function commitPassiveUnmountInsideDeletedTreeOnFiber(
4349 }
4350
4351 function invokeLayoutEffectMountInDEV(fiber: Fiber): void {
4353 - if (__DEV__ && enableStrictEffects) {
4352 + if (__DEV__) {
4353 // We don't need to re-check StrictEffectsMode here.
4354 // This function is only called if that check has already passed.
4355 switch (fiber.tag) {
@@ -4378,7 +4377,7 @@ function invokeLayoutEffectMountInDEV(fiber: Fiber): void {
4377 }
4378
4379 function invokePassiveEffectMountInDEV(fiber: Fiber): void {
4381 - if (__DEV__ && enableStrictEffects) {
4380 + if (__DEV__) {
4381 // We don't need to re-check StrictEffectsMode here.
4382 // This function is only called if that check has already passed.
4383 switch (fiber.tag) {
@@ -4397,7 +4396,7 @@ function invokePassiveEffectMountInDEV(fiber: Fiber): void {
4396 }
4397
4398 function invokeLayoutEffectUnmountInDEV(fiber: Fiber): void {
4400 - if (__DEV__ && enableStrictEffects) {
4399 + if (__DEV__) {
4400 // We don't need to re-check StrictEffectsMode here.
4401 // This function is only called if that check has already passed.
4402 switch (fiber.tag) {
@@ -4427,7 +4426,7 @@ function invokeLayoutEffectUnmountInDEV(fiber: Fiber): void {
4426 }
4427
4428 function invokePassiveEffectUnmountInDEV(fiber: Fiber): void {
4430 - if (__DEV__ && enableStrictEffects) {
4429 + if (__DEV__) {
4430 // We don't need to re-check StrictEffectsMode here.
4431 // This function is only called if that check has already passed.
4432 switch (fiber.tag) {
packages/react-reconciler/src/ReactFiberHooks.new.js
+1 -9
@@ -41,7 +41,6 @@ import {
41 enableUseHook,
42 enableUseMemoCacheHook,
43 enableUseEventHook,
44 - enableStrictEffects,
44 } from 'shared/ReactFeatureFlags';
45 import {
46 REACT_CONTEXT_TYPE,
@@ -602,11 +601,7 @@ export function bailoutHooks(
601 workInProgress.updateQueue = current.updateQueue;
602 // TODO: Don't need to reset the flags here, because they're reset in the
603 // complete phase (bubbleProperties).
605 - if (
606 - __DEV__ &&
607 - enableStrictEffects &&
608 - (workInProgress.mode & StrictEffectsMode) !== NoMode
609 - ) {
604 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
605 workInProgress.flags &= ~(
606 MountPassiveDevEffect |
607 MountLayoutDevEffect |
@@ -1888,7 +1883,6 @@ function mountEffect(
1883 ): void {
1884 if (
1885 __DEV__ &&
1891 - enableStrictEffects &&
1886 (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode
1887 ) {
1888 return mountEffectImpl(
@@ -1984,7 +1978,6 @@ function mountLayoutEffect(
1978 let fiberFlags: Flags = UpdateEffect | LayoutStaticEffect;
1979 if (
1980 __DEV__ &&
1987 - enableStrictEffects &&
1981 (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode
1982 ) {
1983 fiberFlags |= MountLayoutDevEffect;
@@ -2051,7 +2044,6 @@ function mountImperativeHandle<T>(
2044 let fiberFlags: Flags = UpdateEffect | LayoutStaticEffect;
2045 if (
2046 __DEV__ &&
2054 - enableStrictEffects &&
2047 (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode
2048 ) {
2049 fiberFlags |= MountLayoutDevEffect;
packages/react-reconciler/src/ReactFiberHooks.old.js
+1 -9
@@ -41,7 +41,6 @@ import {
41 enableUseHook,
42 enableUseMemoCacheHook,
43 enableUseEventHook,
44 - enableStrictEffects,
44 } from 'shared/ReactFeatureFlags';
45 import {
46 REACT_CONTEXT_TYPE,
@@ -602,11 +601,7 @@ export function bailoutHooks(
601 workInProgress.updateQueue = current.updateQueue;
602 // TODO: Don't need to reset the flags here, because they're reset in the
603 // complete phase (bubbleProperties).
605 - if (
606 - __DEV__ &&
607 - enableStrictEffects &&
608 - (workInProgress.mode & StrictEffectsMode) !== NoMode
609 - ) {
604 + if (__DEV__ && (workInProgress.mode & StrictEffectsMode) !== NoMode) {
605 workInProgress.flags &= ~(
606 MountPassiveDevEffect |
607 MountLayoutDevEffect |
@@ -1888,7 +1883,6 @@ function mountEffect(
1883 ): void {
1884 if (
1885 __DEV__ &&
1891 - enableStrictEffects &&
1886 (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode
1887 ) {
1888 return mountEffectImpl(
@@ -1984,7 +1978,6 @@ function mountLayoutEffect(
1978 let fiberFlags: Flags = UpdateEffect | LayoutStaticEffect;
1979 if (
1980 __DEV__ &&
1987 - enableStrictEffects &&
1981 (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode
1982 ) {
1983 fiberFlags |= MountLayoutDevEffect;
@@ -2051,7 +2044,6 @@ function mountImperativeHandle<T>(
2044 let fiberFlags: Flags = UpdateEffect | LayoutStaticEffect;
2045 if (
2046 __DEV__ &&
2054 - enableStrictEffects &&
2047 (currentlyRenderingFiber.mode & StrictEffectsMode) !== NoMode
2048 ) {
2049 fiberFlags |= MountLayoutDevEffect;
packages/react-reconciler/src/ReactFiberWorkLoop.new.js
+3 -4
@@ -35,7 +35,6 @@ import {
35 enableDebugTracing,
36 enableSchedulingProfiler,
37 disableSchedulerTimeoutInWorkLoop,
38 - enableStrictEffects,
38 skipUnmountedBoundaries,
39 enableUpdaterTracking,
40 enableCache,
@@ -2610,7 +2609,7 @@ function commitRootImpl(
2609 legacyErrorBoundariesThatAlreadyFailed = null;
2610 }
2611
2613 - if (__DEV__ && enableStrictEffects) {
2612 + if (__DEV__) {
2613 if (!rootDidHavePassiveEffects) {
2614 commitDoubleInvokeEffectsInDEV(root, false);
2615 }
@@ -2887,7 +2886,7 @@ function flushPassiveEffectsImpl() {
2886 markPassiveEffectsStopped();
2887 }
2888
2890 - if (__DEV__ && enableStrictEffects) {
2889 + if (__DEV__) {
2890 commitDoubleInvokeEffectsInDEV(root, true);
2891 }
2892
@@ -3356,7 +3355,7 @@ function commitDoubleInvokeEffectsInDEV(
3355 root: FiberRoot,
3356 hasPassiveEffects: boolean,
3357 ) {
3359 - if (__DEV__ && enableStrictEffects) {
3358 + if (__DEV__) {
3359 if (useModernStrictMode) {
3360 let doubleInvokeEffects = true;
3361
packages/react-reconciler/src/ReactFiberWorkLoop.old.js
+3 -4
@@ -35,7 +35,6 @@ import {
35 enableDebugTracing,
36 enableSchedulingProfiler,
37 disableSchedulerTimeoutInWorkLoop,
38 - enableStrictEffects,
38 skipUnmountedBoundaries,
39 enableUpdaterTracking,
40 enableCache,
@@ -2610,7 +2609,7 @@ function commitRootImpl(
2609 legacyErrorBoundariesThatAlreadyFailed = null;
2610 }
2611
2613 - if (__DEV__ && enableStrictEffects) {
2612 + if (__DEV__) {
2613 if (!rootDidHavePassiveEffects) {
2614 commitDoubleInvokeEffectsInDEV(root, false);
2615 }
@@ -2887,7 +2886,7 @@ function flushPassiveEffectsImpl() {
2886 markPassiveEffectsStopped();
2887 }
2888
2890 - if (__DEV__ && enableStrictEffects) {
2889 + if (__DEV__) {
2890 commitDoubleInvokeEffectsInDEV(root, true);
2891 }
2892
@@ -3356,7 +3355,7 @@ function commitDoubleInvokeEffectsInDEV(
3355 root: FiberRoot,
3356 hasPassiveEffects: boolean,
3357 ) {
3359 - if (__DEV__ && enableStrictEffects) {
3358 + if (__DEV__) {
3359 if (useModernStrictMode) {
3360 let doubleInvokeEffects = true;
3361
packages/react-reconciler/src/__tests__/ReactOffscreenStrictMode-test.js
+3 -3
@@ -31,7 +31,7 @@ describe('ReactOffscreenStrictMode', () => {
31 return <span>label</span>;
32 }
33
34 - // @gate __DEV__ && enableStrictEffects && enableOffscreen
34 + // @gate __DEV__ && enableOffscreen
35 it('should trigger strict effects when offscreen is visible', () => {
36 act(() => {
37 ReactNoop.render(
@@ -55,7 +55,7 @@ describe('ReactOffscreenStrictMode', () => {
55 ]);
56 });
57
58 - // @gate __DEV__ && enableStrictEffects && enableOffscreen && useModernStrictMode
58 + // @gate __DEV__ && enableOffscreen && useModernStrictMode
59 it('should not trigger strict effects when offscreen is hidden', () => {
60 act(() => {
61 ReactNoop.render(
@@ -154,7 +154,7 @@ describe('ReactOffscreenStrictMode', () => {
154 });
155 });
156
157 - // @gate __DEV__ && enableStrictEffects && enableOffscreen
157 + // @gate __DEV__ && enableOffscreen
158 it('should double invoke effects on unsuspended child', async () => {
159 let shouldSuspend = true;
160 let resolve;
packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js
-1
@@ -27,7 +27,6 @@ describe('StrictEffectsMode', () => {
27 return gate(
28 flags =>
29 flags.build === 'development' &&
30 - flags.enableStrictEffects &&
30 flags.createRootStrictEffectsByDefault &&
31 flags.dfsEffectsRefactor,
32 );
packages/react-reconciler/src/__tests__/StrictEffectsModeDefaults-test.internal.js
-1
@@ -24,7 +24,6 @@ describe('StrictEffectsMode defaults', () => {
24 act = require('jest-react').act;
25
26 const ReactFeatureFlags = require('shared/ReactFeatureFlags');
27 - ReactFeatureFlags.enableStrictEffects = __DEV__;
27 ReactFeatureFlags.createRootStrictEffectsByDefault = __DEV__;
28 });
29
packages/react/src/__tests__/ReactStrictMode-test.internal.js
-3
@@ -20,9 +20,6 @@ describe('ReactStrictMode', () => {
20 ReactDOMClient = require('react-dom/client');
21
22 act = require('jest-react').act;
23 -
24 - const ReactFeatureFlags = require('shared/ReactFeatureFlags');
25 - ReactFeatureFlags.enableStrictEffects = __DEV__;
23 });
24
25 describe('levels', () => {
packages/shared/ReactFeatureFlags.js
-4
@@ -229,10 +229,6 @@ export const enableSchedulingProfiler = __PROFILE__;
229 // reducers by double invoking them in StrictLegacyMode.
230 export const debugRenderPhaseSideEffectsForStrictMode = __DEV__;
231
232 -// Helps identify code that is not safe for planned Offscreen API and Suspense semantics;
233 -// this feature flag only impacts StrictEffectsMode.
234 -export const enableStrictEffects = __DEV__;
235 -
232 // To preserve the "Pause on caught exceptions" behavior of the debugger, we
233 // replay the begin phase of a failed component inside invokeGuardedCallback.
234 export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -65,7 +65,6 @@ export const enableGetInspectorDataForInstanceInProduction = true;
65 export const enableNewReconciler = false;
66 export const deferRenderPhaseUpdateToNextBatch = false;
67
68 -export const enableStrictEffects = __DEV__;
68 export const createRootStrictEffectsByDefault = false;
69
70 export const disableSchedulerTimeoutInWorkLoop = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -55,7 +55,6 @@ export const enableGetInspectorDataForInstanceInProduction = false;
55 export const enableNewReconciler = false;
56 export const deferRenderPhaseUpdateToNextBatch = false;
57
58 -export const enableStrictEffects = false;
58 export const createRootStrictEffectsByDefault = false;
59 export const enableUseRefAccessWarning = false;
60
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -55,7 +55,6 @@ export const enableGetInspectorDataForInstanceInProduction = false;
55 export const enableNewReconciler = false;
56 export const deferRenderPhaseUpdateToNextBatch = false;
57
58 -export const enableStrictEffects = false;
58 export const createRootStrictEffectsByDefault = false;
59 export const enableUseRefAccessWarning = false;
60
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
-1
@@ -54,7 +54,6 @@ export const enableUseMemoCacheHook = false;
54 export const enableUseEventHook = false;
55 export const enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay = true;
56 export const enableClientRenderFallbackOnTextMismatch = true;
57 -export const enableStrictEffects = false;
57 export const createRootStrictEffectsByDefault = false;
58 export const enableUseRefAccessWarning = false;
59
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -55,7 +55,6 @@ export const enableGetInspectorDataForInstanceInProduction = false;
55 export const enableNewReconciler = false;
56 export const deferRenderPhaseUpdateToNextBatch = false;
57
58 -export const enableStrictEffects = true;
58 export const createRootStrictEffectsByDefault = false;
59 export const enableUseRefAccessWarning = false;
60
packages/shared/forks/ReactFeatureFlags.testing.js
-1
@@ -55,7 +55,6 @@ export const enableGetInspectorDataForInstanceInProduction = false;
55 export const enableNewReconciler = false;
56 export const deferRenderPhaseUpdateToNextBatch = false;
57
58 -export const enableStrictEffects = false;
58 export const createRootStrictEffectsByDefault = false;
59 export const enableUseRefAccessWarning = false;
60
packages/shared/forks/ReactFeatureFlags.testing.www.js
-1
@@ -55,7 +55,6 @@ export const enableGetInspectorDataForInstanceInProduction = false;
55 export const enableNewReconciler = false;
56 export const deferRenderPhaseUpdateToNextBatch = false;
57
58 -export const enableStrictEffects = false;
58 export const createRootStrictEffectsByDefault = false;
59 export const enableUseRefAccessWarning = false;
60
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -57,7 +57,6 @@ export const enableTrustedTypesIntegration = false;
57 export const disableSchedulerTimeoutBasedOnReactExpirationTime = false;
58 export const disableNativeComponentFrames = false;
59 export const createRootStrictEffectsByDefault = false;
60 -export const enableStrictEffects = false;
60 export const allowConcurrentByDefault = true;
61 // You probably *don't* want to add more hardcoded ones.
62 // Instead, try to add them above with the __VARIANT__ value.
packages/shared/forks/ReactFeatureFlags.www.js
-2
@@ -39,8 +39,6 @@ export const {
39 // On WWW, __EXPERIMENTAL__ is used for a new modern build.
40 // It's not used anywhere in production yet.
41
42 -export const enableStrictEffects: boolean =
43 - __DEV__ && dynamicFeatureFlags.enableStrictEffects;
42 export const debugRenderPhaseSideEffectsForStrictMode = __DEV__;
43 export const enableProfilerTimer = __PROFILE__;
44 export const enableProfilerCommitHooks = __PROFILE__;