[instrument] Optional globalGating means no global gating
Mofei Zhang committed
Feb 29, 2024 at 10:04 UTC
9d25ced0187a9d9b591ac9e394a95f846c8772c7
2 files changed
+7
-14
compiler/packages/babel-plugin-react-forget/src/ReactiveScopes/CodegenReactiveFunction.ts
+7
-2
@@ -116,12 +116,17 @@ export function codegenFunction(
116
* __DEV__ and gating identifier to be runtime constants
117
*/
118
let gating: t.Expression;
119
- if (emitInstrumentForget.gating != null) {
119
+ if (
120
+ emitInstrumentForget.gating != null &&
121
+ emitInstrumentForget.globalGating != null
122
+ ) {
123
gating = t.logicalExpression(
124
"&&",
122
- t.identifier(emitInstrumentForget.globalGating ?? "__DEV__"),
125
+ t.identifier(emitInstrumentForget.globalGating),
126
t.identifier(emitInstrumentForget.gating.importSpecifierName)
127
);
128
+ } else if (emitInstrumentForget.gating != null) {
129
+ gating = t.identifier(emitInstrumentForget.gating.importSpecifierName);
130
} else {
131
CompilerError.invariant(emitInstrumentForget.globalGating != null, {
132
reason:
compiler/yarn.lock
-12
@@ -6410,11 +6410,6 @@ hermes-estree@0.17.1:
6410
resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.17.1.tgz#902806a900c185720424ffcf958027821d23c051"
6411
integrity sha512-EdUJms+eRE40OQxysFlPr1mPpvUbbMi7uDAKlScBw8o3tQY22BZ5yx56OYyp1bVaBm+7Cjc3NQz24sJEFXkPxg==
6412
6413
-hermes-estree@0.19.1:
6414
- version "0.19.1"
6415
- resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.19.1.tgz#d5924f5fac2bf0532547ae9f506d6db8f3c96392"
6416
- integrity sha512-daLGV3Q2MKk8w4evNMKwS8zBE/rcpA800nu1Q5kM08IKijoSnPe9Uo1iIxzPKRkn95IxxsgBMPeYHt3VG4ej2g==
6417
-
6413
hermes-estree@0.19.2:
6414
version "0.19.2"
6415
resolved "https://registry.yarnpkg.com/hermes-estree/-/hermes-estree-0.19.2.tgz#b35f59c7fa184ac63a049a9ad37b370c5151bd20"
@@ -6441,13 +6436,6 @@ hermes-parser@0.17.1:
6436
dependencies:
6437
hermes-estree "0.17.1"
6438
6444
-hermes-parser@^0.19.1:
6445
- version "0.19.1"
6446
- resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.19.1.tgz#1044348097165b7c93dc198a80b04ed5130d6b1a"
6447
- integrity sha512-Vp+bXzxYJWrpEuJ/vXxUsLnt0+y4q9zyi4zUlkLqD8FKv4LjIfOvP69R/9Lty3dCyKh0E2BU7Eypqr63/rKT/A==
6448
- dependencies:
6449
- hermes-estree "0.19.1"
6450
-
6439
hermes-parser@^0.19.1:
6440
version "0.19.2"
6441
resolved "https://registry.yarnpkg.com/hermes-parser/-/hermes-parser-0.19.2.tgz#67b0fd92f4d7a374234f58c4f980f816734a7695"