@samitouri / QOS-React-2 / commits / a621cb099d

Fix CI: Download to build instead of base-build (#24677)

Fixes a mistake in #24676. The get_base_build job downloads artifacts to `base-build` instead of `build`, so that sizebot can compare the two directories. For most other jobs, though, we want it to produce the same output as the normal build job.

Andrew Clark committed Jun 6, 2022 at 10:38 UTC a621cb099dafb8bd77370ed4f4d832f049642183
1 file changed +27 -5
.circleci/config.yml
+27 -5
@@ -122,7 +122,28 @@ jobs:
122 paths:
123 - build
124
125 - get_base_build:
125 + download_build:
126 + docker: *docker
127 + environment: *environment
128 + parameters:
129 + revision:
130 + type: string
131 + steps:
132 + - checkout
133 + - run: yarn workspaces info | head -n -1 > workspace_info.txt
134 + - *restore_node_modules
135 + - run:
136 + name: Download artifacts for revision
137 + command: |
138 + git fetch origin main
139 + cd ./scripts/release && yarn && cd ../../
140 + scripts/release/download-experimental-build.js --commit=<< parameters.revision >> --allowBrokenCI
141 + - persist_to_workspace:
142 + root: .
143 + paths:
144 + - base-build
145 +
146 + download_base_build_for_sizebot:
147 docker: *docker
148 environment: *environment
149 steps:
@@ -493,7 +514,7 @@ workflows:
514 # - "-r=www-modern --env=production --variant=true"
515
516 # TODO: Test more persistent configurations?
496 - - get_base_build:
517 + - download_base_build_for_sizebot:
518 filters:
519 branches:
520 ignore:
@@ -506,7 +527,7 @@ workflows:
527 ignore:
528 - main
529 requires:
509 - - get_base_build
530 + - download_base_build_for_sizebot
531 - yarn_build_combined
532 - yarn_lint_build:
533 requires:
@@ -555,12 +576,13 @@ workflows:
576 - main
577 jobs:
578 - setup
558 - - get_base_build:
579 + - download_build:
580 requires:
581 - setup
582 + revision: << pipeline.git.revision >>
583 - build_devtools_and_process_artifacts:
584 requires:
563 - - get_base_build
585 + - download_build
586 - run_devtools_tests_for_versions:
587 requires:
588 - build_devtools_and_process_artifacts