@samitouri / QOS-React-2 / commits / aa80a309b1

[react devtools][easy] Rename LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY to LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY (#25154)

* This more accurately describes what this constant does

Robert Balicki committed Aug 30, 2022 at 13:32 UTC aa80a309b19d59832ffeb82dfb6235da0c93dd42
3 files changed +6 -6
packages/react-devtools-shared/src/constants.js
+1 -1
@@ -51,7 +51,7 @@ export const SESSION_STORAGE_RELOAD_AND_PROFILE_KEY =
51 export const LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS =
52 'React::DevTools::breakOnConsoleErrors';
53
54 -export const LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY =
54 +export const LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY =
55 'React::DevTools::appendComponentStack';
56
57 export const LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY =
packages/react-devtools-shared/src/devtools/views/Settings/SettingsContext.js
+2 -2
@@ -20,7 +20,7 @@ import {
20 COMPACT_LINE_HEIGHT,
21 LOCAL_STORAGE_PARSE_HOOK_NAMES_KEY,
22 LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS,
23 - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
23 + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
24 LOCAL_STORAGE_TRACE_UPDATES_ENABLED_KEY,
25 LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY,
26 LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE,
@@ -117,7 +117,7 @@ function SettingsContextController({
117 appendComponentStack,
118 setAppendComponentStack,
119 ] = useLocalStorageWithLog<boolean>(
120 - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
120 + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
121 true,
122 );
123 const [
packages/react-devtools-shared/src/utils.js
+3 -3
@@ -40,7 +40,7 @@ import {
40 LOCAL_STORAGE_FILTER_PREFERENCES_KEY,
41 LOCAL_STORAGE_OPEN_IN_EDITOR_URL,
42 LOCAL_STORAGE_SHOULD_BREAK_ON_CONSOLE_ERRORS,
43 - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
43 + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
44 LOCAL_STORAGE_SHOW_INLINE_WARNINGS_AND_ERRORS_KEY,
45 LOCAL_STORAGE_HIDE_CONSOLE_LOGS_IN_STRICT_MODE,
46 } from './constants';
@@ -343,7 +343,7 @@ export function saveComponentFilters(
343
344 export function getAppendComponentStack(): boolean {
345 try {
346 - const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY);
346 + const raw = localStorageGetItem(LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY);
347 if (raw != null) {
348 return JSON.parse(raw);
349 }
@@ -353,7 +353,7 @@ export function getAppendComponentStack(): boolean {
353
354 export function setAppendComponentStack(value: boolean): void {
355 localStorageSetItem(
356 - LOCAL_STORAGE_SHOULD_PATCH_CONSOLE_KEY,
356 + LOCAL_STORAGE_SHOULD_APPEND_COMPONENT_STACK_KEY,
357 JSON.stringify(value),
358 );
359 }