[DevTools] devtools-test-shell Regression App fixes (#24644)
Made a couple of fixes to the `devtools-test-shell` * test selectors aren't available in > React v18.0 either, so we'll need to mock the test selector functions there as well * `react-dom/client` should map to `react-dom/client` and not `react-dom`
Luna Ruan committed
May 31, 2022 at 19:13 UTC
b1858b110d2888034355ee6dd9c0b581feabbed3
2 files changed
+8
-2
packages/react-devtools-shell/src/e2e-regression/app.js
+7
-1
@@ -22,4 +22,10 @@ function mountTestApp() {
22
mountTestApp();
23
24
// ReactDOM Test Selector APIs used by Playwright e2e tests
25
-window.parent.REACT_DOM_APP = ReactDOM;
25
+// If they don't exist, we mock them
26
+window.parent.REACT_DOM_APP = {
27
+ createTestNameSelector: name => `[data-testname="${name}"]`,
28
+ findAllNodes: (container, nodes) =>
29
+ container.querySelectorAll(nodes.join(' ')),
30
+ ...ReactDOM,
31
+};
packages/react-devtools-shell/webpack.config.js
+1
-1
@@ -193,7 +193,7 @@ const e2eRegressionApp = semver.lt(REACT_VERSION, '18.0.0')
193
{
194
react: resolve(E2E_APP_BUILD_DIR, 'react'),
195
'react-dom': resolve(E2E_APP_BUILD_DIR, 'react-dom'),
196
- 'react-dom/client': resolve(E2E_APP_BUILD_DIR, 'react-dom'),
196
+ 'react-dom/client': resolve(E2E_APP_BUILD_DIR, 'react-dom/client'),
197
scheduler: resolve(E2E_APP_BUILD_DIR, 'scheduler'),
198
},
199
);