Don't build up mount-ready queue for server side rendering
This is a little faster when rendering iframe/img/form/video/audio on the server.
Ben Alpert committed
Sep 15, 2015 at 21:47 UTC
b7bf1ccafe0efc20e38af9081ace78fe6520ec8c
1 file changed
+6
-24
src/renderers/dom/server/ReactServerRenderingTransaction.js
+6
-24
@@ -13,35 +13,20 @@
13
'use strict';
14
15
var PooledClass = require('PooledClass');
16
-var CallbackQueue = require('CallbackQueue');
16
var Transaction = require('Transaction');
17
18
var assign = require('Object.assign');
20
-var emptyFunction = require('emptyFunction');
21
-
22
-/**
23
- * Provides a `CallbackQueue` queue for collecting `onDOMReady` callbacks
24
- * during the performing of the transaction.
25
- */
26
-var ON_DOM_READY_QUEUEING = {
27
- /**
28
- * Initializes the internal `onDOMReady` queue.
29
- */
30
- initialize: function() {
31
- this.reactMountReady.reset();
32
- },
33
-
34
- close: emptyFunction,
35
-};
19
20
/**
21
* Executed within the scope of the `Transaction` instance. Consider these as
22
* being member methods, but with an implied ordering while being isolated from
23
* each other.
24
*/
42
-var TRANSACTION_WRAPPERS = [
43
- ON_DOM_READY_QUEUEING,
44
-];
25
+var TRANSACTION_WRAPPERS = [];
26
+
27
+var noopCallbackQueue = {
28
+ enqueue: function() {},
29
+};
30
31
/**
32
* @class ReactServerRenderingTransaction
@@ -50,7 +35,6 @@ var TRANSACTION_WRAPPERS = [
35
function ReactServerRenderingTransaction(renderToStaticMarkup) {
36
this.reinitializeTransaction();
37
this.renderToStaticMarkup = renderToStaticMarkup;
53
- this.reactMountReady = CallbackQueue.getPooled(null);
38
this.useCreateElement = false;
39
}
40
@@ -69,7 +53,7 @@ var Mixin = {
53
* @return {object} The queue to collect `onDOMReady` callbacks with.
54
*/
55
getReactMountReady: function() {
72
- return this.reactMountReady;
56
+ return noopCallbackQueue;
57
},
58
59
/**
@@ -77,8 +61,6 @@ var Mixin = {
61
* instance to be reused.
62
*/
63
destructor: function() {
80
- CallbackQueue.release(this.reactMountReady);
81
- this.reactMountReady = null;
64
},
65
};
66